Support CSX Jan 2020 zone plate experiment #75
Conversation
leofang
force-pushed
the
csx_zone_plate
branch
from
071902e to
03d9392
Compare
1. initialize to 0.0 2. change allowed range to [-180, 180]
leofang
force-pushed
the
csx_zone_plate
branch
from
8019cbe to
476fce3
Compare
TODO: this may not be the best practice. Should do this elsewhere, like when loading data?
Now the the behavior is - if the window is closed, one can reopen it with everything intact as long as there is no need to reload (due to change of scan number, etc) - if reload is needed, the window will be forced close so that a fresh window can be opened. TODO: need a reset button for the roi window
|
Zero-out does not seem to behave correctly. Investigating... EDIT: fixed in d10e7ee |
TODO: clean up the useless code
|
For the flat field support, note the commit message in 03871d6. This is a short-term solution as the usage is not very intuitive, but this is what I can do in one hour without going through the painful process of designing GUI elements. Will have to revisit this later. |
To correct flat field, type in 7, instead of 3, scan ids in the Associate Scans window, in this order: (dark8, dark2, dark1, flat_scan_num, flat_dark8, flat_dark2, flat_dark1). Two notes: 1. To use this feature, must apply the patch in NSLS-II-CSX/csxtools#68 (comment) to csxtools, otherwise the error from NSLS-II-CSX/csxtools#68 would happen. 2. I observed a vertical black stripe in the corrected image, not sure if this is expected.
leofang
force-pushed
the
csx_zone_plate
branch
from
b122b94 to
03871d6
Compare
Addressed items 2 & 4 in NSLS2#80.
|
|
This bug exists in both HXN and CSX databroker accesses.
This is a non-compatible change in that in addition to restore the zoom-in status, all values and internal states, including ROIs, bad pixels, log scale, etc, are also reset. Close NSLS2#81.
leofang
changed the title
|
@mrakitin If you are interested in (or have time for 😆) reviewing this PR, I'll be more than happy. If you don't have time, please go ahead and merge for me. I'll then proceed to do some lightweight refactoring to prepare for #74 (perhaps after I add a few new solvers to the backend). We'll have one more shot to review all the changes before I release v1.4.0 (#70). Thanks! |
|
Hi Leo, I will review it tonight. |
|
@mrakitin I am going to merge this for now, as @xiaojinghuang from HXN needs 476fce3. Going to deploy a hotfix for them. Please feel free to revisit anytime. |
|
Sounds good. It has fallen off my priority list somehow. Will reiterate later. |
cc: @mrakitin @wen-hu @PabloEnfedaque