Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DOFs and Objectives for better control of Pareto optimization #66

Merged
merged 8 commits into from
Apr 23, 2024

Conversation

thomaswmorris
Copy link
Contributor

@thomaswmorris thomaswmorris commented Apr 15, 2024

This PR does two main things:

  1. We interpret objectives as either a fitness (to be minimized or maximized) or a constraint (to satisfy some condition). Optimality is then the optimal/Pareto-efficient fitness within all the constriants.
  2. We generalize the notion of a transform, so that we can transform the inputs and outputs with any function we want to better describe them using a GP.

Some small things:

  • A lot of processes are more robust and numerically stable.
  • We delete a lot of spaghetti code.
  • Add more to the documentation.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mrakitin
Copy link
Member

Please rebase on main to eliminate the commits from already merged #64.

@thomaswmorris thomaswmorris force-pushed the improve-dofs-and-objs branch from 8e8917b to 3ad3a0e Compare April 18, 2024 20:41
@thomaswmorris thomaswmorris requested a review from mrakitin April 21, 2024 22:32
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but it needs a few minor touch-ups suggested below.

docs/source/objectives.rst Outdated Show resolved Hide resolved
docs/source/objectives.rst Outdated Show resolved Hide resolved
docs/source/objectives.rst Outdated Show resolved Hide resolved
docs/source/objectives.rst Show resolved Hide resolved
src/blop/agent.py Outdated Show resolved Hide resolved
src/blop/dofs.py Outdated Show resolved Hide resolved
src/blop/dofs.py Outdated Show resolved Hide resolved
src/blop/dofs.py Outdated Show resolved Hide resolved
src/blop/objectives.py Outdated Show resolved Hide resolved
src/blop/objectives.py Outdated Show resolved Hide resolved
@thomaswmorris thomaswmorris merged commit be5b001 into NSLS-II:main Apr 23, 2024
5 checks passed
thomaswmorris added a commit to thomaswmorris/blop that referenced this pull request Jul 15, 2024
Improve DOFs and Objectives for better control of Pareto optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants