edits to pbs.py to improve usability #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with the difference. It would be great if others can check. |
dkimpara
changed the title
dkimpara
changed the title
dkimpara
force-pushed
the
resolving_symlink_issue
branch
from
37897e9 to
2ff991c
Compare
dkimpara
force-pushed
the
resolving_symlink_issue
branch
from
2ff991c to
f8a005f
Compare
djgagne
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, if you tried to use a config where the path included symlinks, the logic would delete the config file at save_loc/model.yml even though it is the same file. tested on derecho with launch option
explanation:
realpathresolves symlinks and then appliesabspathnew feature:
testing:
checkout the branch, update your credit env, update the env in unet_test.yml with your env then launch a test with:
python applications/train.py -c [path-to-your-repo]miles-credit/config/unet_test.yml -l 1see this dir for my results:
/glade/work/dkimpara/CREDIT_runs/test_1dg_unet/