add taylordiagram example #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafitzgerald
requested changes
Jan 23, 2024
docs/examples/taylor.ipynb
Outdated
Comment on lines
7
to
9
| "# `set_titles_and_labels`\n", | ||
| "\n", | ||
| "This notebook is a simple example of the GeoCAT-viz function <a href=\"../user_api/generated/geocat.viz.util.set_titles_and_labels.html#geocat-viz.util.set_titles_and_labels\">set_titles_and_labels</a>." |
There was a problem hiding this comment.
Looks like this got missed.
It looks like it's causing the index on the left to be incorrect as well. I couldn't find the example at first.
https://geocat-viz--186.org.readthedocs.build/en/186/examples/taylor.html
There was a problem hiding this comment.
hmm it seems like a commit didn't publish? Because I definitely changed this locally. The link seems off too
docs/examples/taylor.ipynb
Outdated
| "import numpy as np\n", | ||
| "import xarray as xr\n", | ||
| "\n", | ||
| "import cftime\n", |
There was a problem hiding this comment.
The example seems to be failing on the cftime import (though not loudly - which is concerning).
https://geocat-viz--186.org.readthedocs.build/en/186/examples/taylor.html
Do we need this or is it something we could strip out?
kafitzgerald
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds Taylor Diagram example script
Related to #126
PR Checklist
General
closes #XXXto the PR description where XXX is the number of the issue.docs/release-notes.rstin a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecatedprecommit. To set up on your local, runpre-commit installfrom the top level of the repository. To manually run pre-commits, usepre-commit run --all-filesand re-add any changed files before committing again and pushing.Examples
docs/examples/folderdocs/examples.rsttoctreedocs/gallery.ymlwith appropriate thumbnail photo indocs/_static/thumbnails/