-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIR-1256 support time in mods date issued #918
MIR-1256 support time in mods date issued #918
Conversation
f74c992
to
1069813
Compare
1069813
to
f83b863
Compare
mir-module/src/main/resources/META-INF/resources/js/mir/xeditor-form.js
Outdated
Show resolved
Hide resolved
3fddd43
to
ccaef67
Compare
It's been a few days since I last looked at this PR. Please remind me, with the current implementation, how is the per-field-configuration made, to set whether it is a date-and-time-field or just a date-field? |
In editor-includes.xed, you can configure two attributes to control the behavior of date fields: showDateTimeOption: Set this to true to include the time option in date fields. This mainly influences whether you can choose this option if you have a dropdown with many options such as Date, Daterange and Datetime. startsWithDateTime: Set this to true to make the date-time option the default when the page with the date field is loaded. These attributes can be added to the textfields of templates inside editor-includes.xed. If these attributes are left empty or set to false, the standard behavior of the date fields remains unchanged. The logic for that is mostly handled in mir2xeditor. I have added the attributes as an example in one template, set to false, so the behavior should not change unless changed to true. Edit: Meant mir:dateRange and not mir:textfield. Sorry about that miscommunication. |
I've noticed a potential problem (see comments). I've also tried out your PR extensively with my application and an unmodified MIR (current version of MyCoRe- and MIR- Please demonstrate the feature during the next web conference, or guide me through using is. |
Implements a Timepicker, merge conflicts fixed.
TimeWidget is set to false by default.
…e time in datetimepicker
e44661a
to
fa8dee0
Compare
Link to jira.