Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIR-1256 support time in mods date issued #918

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

Antoniafriedrich
Copy link
Contributor

@Possommi Possommi changed the title Issues/mir 1256 support time in mods date issued MIR-1256 support time in mods date issued Nov 14, 2023
@Antoniafriedrich Antoniafriedrich force-pushed the issues/MIR-1256-support-time-in-mods-date-issued branch from f74c992 to 1069813 Compare November 14, 2023 13:38
@Antoniafriedrich Antoniafriedrich force-pushed the issues/MIR-1256-support-time-in-mods-date-issued branch from 1069813 to f83b863 Compare January 8, 2024 10:44
@Antoniafriedrich Antoniafriedrich changed the base branch from 2023.06.x to main September 2, 2024 11:36
@Antoniafriedrich Antoniafriedrich force-pushed the issues/MIR-1256-support-time-in-mods-date-issued branch from 3fddd43 to ccaef67 Compare September 2, 2024 11:46
@toKrause
Copy link
Contributor

toKrause commented Sep 9, 2024

It's been a few days since I last looked at this PR.

Please remind me, with the current implementation, how is the per-field-configuration made, to set whether it is a date-and-time-field or just a date-field?

@Antoniafriedrich
Copy link
Contributor Author

Antoniafriedrich commented Sep 16, 2024

In editor-includes.xed, you can configure two attributes to control the behavior of date fields:

showDateTimeOption: Set this to true to include the time option in date fields. This mainly influences whether you can choose this option if you have a dropdown with many options such as Date, Daterange and Datetime.

startsWithDateTime: Set this to true to make the date-time option the default when the page with the date field is loaded.

These attributes can be added to the textfields of templates inside editor-includes.xed. If these attributes are left empty or set to false, the standard behavior of the date fields remains unchanged.
It should be possible to create a new template with these attributes and add it to your MyCoReWebPage.

The logic for that is mostly handled in mir2xeditor.

I have added the attributes as an example in one template, set to false, so the behavior should not change unless changed to true.

Edit: Meant mir:dateRange and not mir:textfield. Sorry about that miscommunication.

@toKrause
Copy link
Contributor

toKrause commented Sep 17, 2024

I've noticed a potential problem (see comments).

I've also tried out your PR extensively with my application and an unmodified MIR (current version of MyCoRe- and MIR-main-branch respectively) and was so far unable to even see the UI for entering a time value, let alone check, if everything works consistently.

Please demonstrate the feature during the next web conference, or guide me through using is.

@Antoniafriedrich Antoniafriedrich force-pushed the issues/MIR-1256-support-time-in-mods-date-issued branch from e44661a to fa8dee0 Compare September 24, 2024 14:53
@yagee-de yagee-de merged commit 9df94f0 into main Oct 8, 2024
2 checks passed
@yagee-de yagee-de deleted the issues/MIR-1256-support-time-in-mods-date-issued branch October 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants