Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced second 'Add to Cart' button with 'Buy Now' button #121

Merged

Conversation

sitambhra
Copy link
Contributor

Pull Request Template

Summary

This PR addresses the issue raised in the ticket #107.

It replaces the second "Add to Cart" button with a "Buy Now" button on the product pages of the coffee shop website. The "Buy Now" button directly takes the user to the checkout page, improving the user experience by eliminating redundancy and confusion.
Fixes #107 (issue)

Before:
image
After:
image

After Clicking on Buy Now, it will redirect directly to Check out Page:
image

Request to Change Label from "Beginner" to "Intermediate/Advanced":

I request the label be changed to "Intermediate/Advanced" because the task involves modifying React components, understanding React routing, and managing state. The change required a deeper understanding of the app’s flow and interactivity, which goes beyond beginner-level tasks.

Type of Change

Please mark [X] for applicable items:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

  • Manually tested the "Buy Now" button to ensure it redirects to the checkout page.
  • Verified the "Add to Cart" button remains functional.
  • Checked for any console errors or warnings.
  • Tested responsiveness on both desktop and mobile.

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 2:56pm

Copy link

github-actions bot commented Jan 2, 2025

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@Mujtabaa07
Copy link
Owner

Screenshot 2025-01-02 140850
@Sitambhra02 align the buttons and in the checkout page, the font checkout, it is merged in the navbar

@Mujtabaa07 Mujtabaa07 added INTERMEDIATE SWOC Social Winter Of Code labels Jan 2, 2025
@Mujtabaa07
Copy link
Owner

In this issue just make for buttons #123 this issue for checkout page, and make a route for checkout page

Copy link

vercel bot commented Jan 2, 2025

Deployment failed with the following error:

Resource is limited - try again in 34 minutes (more than 100, code: "api-deployments-free-per-day").

@Mujtabaa07
Copy link
Owner

Deployment failed with the following error:

Resource is limited - try again in 34 minutes (more than 100, code: "api-deployments-free-per-day").

@Sitambhra02 the PR will get merge after this limit goes

@Mujtabaa07 Mujtabaa07 merged commit abc290b into Mujtabaa07:main Jan 2, 2025
2 checks passed
@Mujtabaa07
Copy link
Owner

🎉 Congratulations on Your Merged PR!

Thank you @Sitambhra02 for your contribution!

What's Next?

Keep up the fantastic work! 🚀

@sitambhra
Copy link
Contributor Author

@Mujtabaa07
I noticed that you have not assigned me points on OSlead for my PR's.
Could you assign them at the earliest?

PR-1: Fix Navbar and Checkout Heading Overlap Issue #143
PR-2: Replaced second 'Add to Cart' button with 'Buy Now' button #121

@sitambhra
Copy link
Contributor Author

@Mujtabaa07
This is to remind you that you have not assigned me points for my PR's.
Can you update them at earliest possible?

@Mujtabaa07
Copy link
Owner

@Mujtabaa07 This is to remind you that you have not assigned me points for my PR's. Can you update them at earliest possible?

@Sitambhra02 I wanted to address the issue regarding the assignment of points. You contributed on the second day after the program began, but the leaderboard only started tracking from January 5th. Due to some challenges, I managed to join the leaderboard on January 6th.

The main issue lies in the fact that PRs don’t receive points if they are merged more than 7 days ago. I have already informed them about this concern, and they assured me that they would look into it. If this issue gets resolved, I’ll assign the points as soon as possible.

Thank you once again for your valuable contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADVANCE SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Replace One "Add to Cart" Button with "Buy Now"
2 participants