Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-15023] Improve docker images #35

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[DOP-15023] Improve docker images #35

merged 1 commit into from
Apr 15, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Apr 11, 2024

Change Summary

  • Instead of copying the entire repo with all the configs into worker image, copy just syncmaster folder contents.
  • Add entrypoint for backend image. It runs migrations first, and only after that it starts an application.
  • Add entrypoint for worker image. It starts celery worker with few fixed args, and then applies user-defined args.
  • Add syncmaster.backend python module which passes application factory to uvicorn, and then applies user-defined args. This is to keep Horizon and SyncMaster scripts in sync.
  • Add syncmaster.db.migrations python module which passes migrations config location to alembic, and then applies user-defined args. This is to keep Horizon and SyncMaster scripts in sync.
  • Add healthchecks to docker containers (excluding Oracle).
  • Few small cosmetic changes.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.73%. Comparing base (b7f4d02) to head (a6537e0).

Files Patch % Lines
syncmaster/backend/__init__.py 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #35      +/-   ##
===========================================
- Coverage    91.73%   91.73%   -0.01%     
===========================================
  Files           84       84              
  Lines         2444     2443       -1     
  Branches       305      305              
===========================================
- Hits          2242     2241       -1     
  Misses         145      145              
  Partials        57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from 3da62c3 to c430d6b Compare April 11, 2024 13:13
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from c430d6b to b080b01 Compare April 11, 2024 13:14
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from b080b01 to 3f277be Compare April 11, 2024 13:15
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from 3f277be to b423f67 Compare April 11, 2024 13:24
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from b423f67 to a8ab2b5 Compare April 11, 2024 13:35
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from a8ab2b5 to 0e173cb Compare April 11, 2024 14:25
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from 0e173cb to e92f4fe Compare April 11, 2024 14:34
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from e92f4fe to c819d1a Compare April 11, 2024 14:53
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from c819d1a to c6d964c Compare April 11, 2024 16:02
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from c6d964c to 1e73e02 Compare April 12, 2024 13:36
@dolfinus dolfinus force-pushed the feature/DOP-15023 branch from 458bd77 to a6537e0 Compare April 12, 2024 14:42
@dolfinus dolfinus marked this pull request as ready for review April 12, 2024 14:42
@dolfinus dolfinus merged commit 759a89d into develop Apr 15, 2024
16 checks passed
@dolfinus dolfinus deleted the feature/DOP-15023 branch April 15, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants