Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22344] Add transformations for Transfers with file filtering #198

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Feb 7, 2025

Change Summary

  • Added a schema for FileMetadataFilter transformation:

    {
      "type": "file_metadata_filter",
      "filters": [
        {
          "type": "name_glob",
          "value": "*.csv"
        },
        {
          "type": "name_regexp",
          "value": "^1234$"
        },
        {
          "type": "file_size_min",
          "value": "1Kb"
        },
        {
          "type": "file_size_max",
          "value": "1Gb"
        }
      ]
    }
  • Supported filter types

    • name_glob
    • name_regexp
    • file_size_min
    • file_size_max
  • Implemented logic in the worker to handle FileMetadataFilter transformations: if a filter is present, it is applied to FileDownloader(filters=[...]) for FileProtocolHandlers.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Feb 7, 2025
@IlyasDevelopment IlyasDevelopment merged commit 805e761 into develop Feb 10, 2025
23 of 24 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-22344 branch February 10, 2025 07:40
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (6e1f1f9) to head (af05c06).
Report is 1 commits behind head on develop.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (92.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #198   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants