Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22141] Add logic for handling SFTP transfers #189

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Jan 27, 2025

Change Summary

  • Added necessary DTOs for SFTP integration
  • Implemented an SFTP handler:
    • For reading, used a combination of FileDownloader and FileDFReader
    • For writing, used FileDFWriter and FileUploader
  • Added a container with an SFTP server for testing purposes
  • Developed integration tests for reading and writing files via SFTP
  • Updated CI pipeline to include the execution of integration tests
  • Note: Connections are created with SFTP(compress=False) to avoid errors caused by combining compressed files with compression at the SCP protocol level.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Jan 27, 2025
.env.docker Outdated Show resolved Hide resolved
@IlyasDevelopment IlyasDevelopment marked this pull request as ready for review January 28, 2025 13:50
@IlyasDevelopment IlyasDevelopment merged commit d820def into develop Jan 29, 2025
20 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-22141 branch January 29, 2025 09:27
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (85618f1) to head (421fe46).
Report is 1 commits behind head on develop.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (92.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #189   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants