[DOP-21928] add success notifications (#52)

Co-authored-by: Zabilsya <kvcherniko@mts.ru>
MobileTeleSystems · Dec 13, 2024 · 67e6fda · 67e6fda
1 parent 7b41e07
commit 67e6fda
Show file tree

Hide file tree

Showing 18 changed files with 36 additions and 3 deletions.
diff --git a/src/entities/connection/api/hooks/useDeleteConnection/index.ts b/src/entities/connection/api/hooks/useDeleteConnection/index.ts
@@ -15,6 +15,9 @@ export const useDeleteConnection = (data: DeleteConnectionRequest): UseMutationR
     onSuccess: () => {
       queryClient.invalidateQueries({ queryKey: [ConnectionQueryKey.GET_CONNECTIONS] });
       queryClient.removeQueries({ queryKey: [ConnectionQueryKey.GET_CONNECTION, data.id] });
+      notification.success({
+        message: 'Connection was deleted successfully',
+      });
     },
     onError: (error) => {
       notification.error({

diff --git a/src/entities/connection/ui/ConnectionTypeForm/index.tsx b/src/entities/connection/ui/ConnectionTypeForm/index.tsx
@@ -15,7 +15,7 @@ export const ConnectionTypeForm = ({ initialType, isRequiredSensitiveFields = tr
 
   return (
     <>
-      <Form.Item label="type" name="type" rules={[{ required: true }]}>
+      <Form.Item label="Type" name="type" rules={[{ required: true }]}>
         <Select
           size="large"
           options={CONNECTION_TYPE_SELECT_OPTIONS}

diff --git a/src/entities/group/api/hooks/useDeleteGroupUser/index.ts b/src/entities/group/api/hooks/useDeleteGroupUser/index.ts
@@ -14,6 +14,9 @@ export const useDeleteGroupUser = (data: DeleteGroupUserRequest): UseMutationRes
     mutationFn: () => groupService.deleteGroupUser(data),
     onSuccess: () => {
       queryClient.invalidateQueries({ queryKey: [GroupQueryKey.GET_GROUP_USERS, data.groupId] });
+      notification.success({
+        message: 'Group was deleted successfully',
+      });
     },
     onError: (error) => {
       notification.error({

diff --git a/src/entities/queue/api/hooks/useDeleteQueue/index.ts b/src/entities/queue/api/hooks/useDeleteQueue/index.ts
@@ -15,6 +15,9 @@ export const useDeleteQueue = (data: DeleteQueueRequest): UseMutationResult => {
     onSuccess: () => {
       queryClient.invalidateQueries({ queryKey: [QueueQueryKey.GET_QUEUES] });
       queryClient.removeQueries({ queryKey: [QueueQueryKey.GET_QUEUE, data.id] });
+      notification.success({
+        message: 'Queue was deleted successfully',
+      });
     },
     onError: (error) => {
       notification.error({

diff --git a/src/entities/run/api/hooks/useCreateRun/index.ts b/src/entities/run/api/hooks/useCreateRun/index.ts
@@ -14,6 +14,9 @@ export const useCreateRun = (data: CreateRunRequest): UseMutationResult => {
     mutationFn: () => runService.createRun(data),
     onSuccess: () => {
       queryClient.invalidateQueries({ queryKey: [RunQueryKey.GET_RUNS, data.transfer_id] });
+      notification.success({
+        message: 'Transfer run was created successfully',
+      });
     },
     onError: (error) => {
       notification.error({

diff --git a/src/entities/transfer/api/hooks/useDeleteTransfer/index.ts b/src/entities/transfer/api/hooks/useDeleteTransfer/index.ts
@@ -15,6 +15,9 @@ export const useDeleteTransfer = (data: DeleteTransferRequest): UseMutationResul
     onSuccess: () => {
       queryClient.invalidateQueries({ queryKey: [TransferQueryKey.GET_TRANSFERS] });
       queryClient.removeQueries({ queryKey: [TransferQueryKey.GET_TRANSFER, data.id] });
+      notification.success({
+        message: 'Transfer was deleted successfully',
+      });
     },
     onError: (error) => {
       notification.error({

diff --git a/src/features/connection/CreateConnection/index.tsx b/src/features/connection/CreateConnection/index.tsx
@@ -29,6 +29,7 @@ export const CreateConnection = ({ group }: CreateConnectionProps) => {
     <ManagedForm<CreateConnectionForm, Connection>
       mutationFunction={handleCreateConnection}
       onSuccess={onSuccess}
+      successMessage="Connection was created successfully"
       keysInvalidateQueries={[[{ queryKey: [ConnectionQueryKey.GET_CONNECTIONS, group.id] }]]}
     >
       <FormCurrentGroupDescription groupName={group.name} />

diff --git a/src/features/connection/UpdateConnection/index.tsx b/src/features/connection/UpdateConnection/index.tsx
@@ -31,6 +31,7 @@ export const UpdateConnection = ({ connection, group }: UpdateConnectionProps) =
       mutationFunction={handleUpdateConnection}
       initialValues={getUpdateConnectionInitialValues(connection)}
       onSuccess={onSuccess}
+      successMessage="Connection was updated successfully"
       keysInvalidateQueries={[
         [{ queryKey: [ConnectionQueryKey.GET_CONNECTIONS, group.id] }],
         [{ queryKey: [ConnectionQueryKey.GET_CONNECTION, connection.id] }],

diff --git a/src/features/group/AddGroupUser/index.tsx b/src/features/group/AddGroupUser/index.tsx
@@ -15,6 +15,7 @@ export const AddGroupUser = ({ groupId, onSuccess, onCancel }: AddGroupUserProps
     <ManagedForm<AddGroupUserForm, null>
       mutationFunction={handleAddGroupUser}
       onSuccess={onSuccess}
+      successMessage="User was added to group successfully"
       keysInvalidateQueries={[[{ queryKey: [GroupQueryKey.GET_GROUP_USERS, groupId] }]]}
     >
       <Form.Item label="User" name="userId" rules={[{ required: true }]}>

diff --git a/src/features/group/CreateGroup/index.tsx b/src/features/group/CreateGroup/index.tsx
@@ -19,13 +19,14 @@ export const CreateGroup = () => {
     <ManagedForm
       mutationFunction={groupService.createGroup}
       onSuccess={onSuccess}
+      successMessage="Group was created successfully"
       keysInvalidateQueries={[[{ queryKey: [GroupQueryKey.GET_GROUPS] }]]}
     >
       <Form.Item label="Name" name="name" rules={[{ required: true }]}>
         <Input size="large" />
       </Form.Item>
 
-      <Form.Item label="Description" name="description">
+      <Form.Item label="Description" name="description" rules={[{ required: true }]}>
         <Input size="large" />
       </Form.Item>
 

diff --git a/src/features/group/UpdateGroup/index.tsx b/src/features/group/UpdateGroup/index.tsx
@@ -28,6 +28,7 @@ export const UpdateGroup = ({ group }: UpdateGroupProps) => {
       mutationFunction={handleUpdateGroup}
       initialValues={getUpdateGroupInitialValues(group)}
       onSuccess={onSuccess}
+      successMessage="Group was updated successfully"
       keysInvalidateQueries={[
         [{ queryKey: [GroupQueryKey.GET_GROUPS] }],
         [{ queryKey: [GroupQueryKey.GET_GROUP, group.id] }],
@@ -37,7 +38,7 @@ export const UpdateGroup = ({ group }: UpdateGroupProps) => {
         <Input size="large" />
       </Form.Item>
 
-      <Form.Item label="Description" name="description">
+      <Form.Item label="Description" name="description" rules={[{ required: true }]}>
         <Input size="large" />
       </Form.Item>
 

diff --git a/src/features/group/UpdateGroupUser/index.tsx b/src/features/group/UpdateGroupUser/index.tsx
@@ -19,6 +19,7 @@ export const UpdateGroupUser = ({ groupId, user, onSuccess, onCancel }: UpdateGr
       initialValues={getUpdateGroupUserInitialValues(user)}
       mutationFunction={handleUpdateGroupUser}
       onSuccess={onSuccess}
+      successMessage="User role was updated successfully"
       keysInvalidateQueries={[[{ queryKey: [GroupQueryKey.GET_GROUP_USERS, groupId] }]]}
     >
       <div className={classes.formMain}>

diff --git a/src/features/queue/CreateQueue/index.tsx b/src/features/queue/CreateQueue/index.tsx
@@ -25,6 +25,7 @@ export const CreateQueue = ({ group }: CreateQueueProps) => {
     <ManagedForm<CreateQueueForm, Queue>
       mutationFunction={handleCreateQueue}
       onSuccess={onSuccess}
+      successMessage="Queue was created successfully"
       keysInvalidateQueries={[[{ queryKey: [QueueQueryKey.GET_QUEUES, group.id] }]]}
     >
       <FormCurrentGroupDescription groupName={group.name} />

diff --git a/src/features/queue/UpdateQueue/index.tsx b/src/features/queue/UpdateQueue/index.tsx
@@ -27,6 +27,7 @@ export const UpdateQueue = ({ queue, group }: UpdateQueueProps) => {
       mutationFunction={handleUpdateQueue}
       initialValues={getUpdateQueueInitialValues(queue)}
       onSuccess={onSuccess}
+      successMessage="Queue was updated successfully"
       keysInvalidateQueries={[
         [{ queryKey: [QueueQueryKey.GET_QUEUES, group.id] }],
         [{ queryKey: [QueueQueryKey.GET_QUEUE, queue.id] }],

diff --git a/src/shared/ui/ManagedForm/index.tsx b/src/shared/ui/ManagedForm/index.tsx
@@ -13,6 +13,7 @@ export const ManagedForm = <T extends object, R>({
   children,
   mutationFunction,
   onSuccess,
+  successMessage,
   keysInvalidateQueries = [],
   isHiddenLoadingOnSuccess = false,
   onError = () => undefined,
@@ -35,6 +36,11 @@ export const ManagedForm = <T extends object, R>({
         if (isHiddenLoadingOnSuccess) {
           setLoading(false);
         }
+        if (successMessage) {
+          notification.success({
+            message: successMessage,
+          });
+        }
       },
       onError: (error) => {
         onError(error);

diff --git a/src/shared/ui/ManagedForm/types.ts b/src/shared/ui/ManagedForm/types.ts
@@ -12,6 +12,8 @@ export interface ManagedFormProps<T, R> extends Omit<FormProps<T>, 'form' | 'onF
   mutationFunction: (params: T) => Promise<R>;
   /** Callback on success response from request */
   onSuccess: (response: R) => void;
+  /** Notification message text on success response from request */
+  successMessage?: string;
   /** Callback on error response from request */
   onError?: (error: unknown) => void;
   /** Keys for invalidate cache of other requests */

diff --git a/src/widgets/transfer/CreateTransfer/index.tsx b/src/widgets/transfer/CreateTransfer/index.tsx
@@ -27,6 +27,7 @@ export const CreateTransfer = ({ group }: CreateTransferProps) => {
       initialValues={CREATE_TRANSFER_INITIAL_VALUES}
       mutationFunction={handleCreateTransfer}
       onSuccess={onSuccess}
+      successMessage="Transfer was created successfully"
       keysInvalidateQueries={[[{ queryKey: [TransferQueryKey.GET_TRANSFERS, group.id] }]]}
     >
       <MutateTransferForm group={group} onCancel={onCancel} />

diff --git a/src/widgets/transfer/UpdateTransfer/index.tsx b/src/widgets/transfer/UpdateTransfer/index.tsx
@@ -27,6 +27,7 @@ export const UpdateTransfer = ({ transfer, group }: UpdateTransferProps) => {
       initialValues={transferInitialValues}
       mutationFunction={handleUpdateTransfer}
       onSuccess={onSuccess}
+      successMessage="Transfer was updated successfully"
       keysInvalidateQueries={[
         [{ queryKey: [TransferQueryKey.GET_TRANSFERS, group.id] }],
         [{ queryKey: [TransferQueryKey.GET_TRANSFER, transfer.id] }],