Fix get_train_with_targets_for_reranker method #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blondered
reviewed
Jan 16, 2025
Co-authored-by: Daria <93913290+blondered@users.noreply.github.com>
In48semenov
reviewed
Jan 29, 2025
Co-authored-by: Andrey Semenov <43339130+In48semenov@users.noreply.github.com>
Co-authored-by: Andrey Semenov <43339130+In48semenov@users.noreply.github.com>
Co-authored-by: Andrey Semenov <43339130+In48semenov@users.noreply.github.com>
Co-authored-by: Andrey Semenov <43339130+In48semenov@users.noreply.github.com>
Co-authored-by: Andrey Semenov <43339130+In48semenov@users.noreply.github.com>
Co-authored-by: Andrey Semenov <43339130+In48semenov@users.noreply.github.com>
Co-authored-by: Andrey Semenov <43339130+In48semenov@users.noreply.github.com>
Co-authored-by: Andrey Semenov <43339130+In48semenov@users.noreply.github.com>
…gakova/RecTools into experimental/two_stage
blondered
reviewed
Jan 30, 2025
|
|
||
| def test_prepare_training_pool( | ||
| self, | ||
| reranker_catboost_ranker: CatBoostReranker, |
There was a problem hiding this comment.
Please move ranker and classifier to pytest.parametrize decorator for all of the tests where you need to test both approaches.
Here is an example on how to organize code when you have different outputs for different parameters:
Co-authored-by: Andrey Semenov <43339130+In48semenov@users.noreply.github.com>
feldlime
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make changes to the
get_train_with_targets_for_rerankermethod to separate the retrieval of sampled candidates and unsampled candidates from first-stage candidate generators for the reranker.