chore: Refactor RSI test code and add almostEqual function #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahParks
reviewed
May 11, 2024
| @@ -72,13 +77,13 @@ func TestRSI_Calculate(t *testing.T) { | |||
|
|
|||
| r, result := rsi.New(prices[:initialLength]) | |||
| if result != results[0] { | |||
There was a problem hiding this comment.
Suggested change
| if result != results[0] { | |
| if !almostEqual(result, results[0], 0.000001) { |
|
Does floating point precision have small deviations between platforms? What operating system and version of Go have you noticed tests failing on? |
|
Darwin Kernel Version 23.4.0
go1.21.6 darwin/arm64
…On Sat, May 11, 2024 at 7:23 AM Micah Parks ***@***.***> wrote:
Does floating point precision have small deviations between platforms?
What operating system and version of Go have you noticed tests failing on?
—
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCXJFCTKI4F6EP74HDCCB3ZBYSXRAVCNFSM6AAAAABHR62PNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVHA2TKNRYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Would you include the full test output? I don't have access to a Macbook and am curious to see the output. |
|
(base) ***@***.*** go-rsi % go test
--- FAIL: TestRSI_Calculate (0.00s)
rsi_test.go:86: 74.05997693194935 74.05997693194935
rsi_test.go:86: 66.85220483413693 66.85220483413693
rsi_test.go:86: 70.13392792714788 70.13392792714788
rsi_test.go:86: 59.4965020993055 59.496502099305495
rsi_test.go:86: 53.847989515796236 53.847989515796236
rsi_test.go:86: 54.31507914768538 54.31507914768538
rsi_test.go:86: 47.70441856222932 47.70441856222932
rsi_test.go:86: 51.88513226122602 51.88513226122602
rsi_test.go:86: 52.23363827029182 52.23363827029182
rsi_test.go:86: 42.115354879279415 42.11535487927941
rsi_test.go:86: 44.80693633023409 44.80693633023408
rsi_test.go:86: 42.84043542606478 42.84043542606477
rsi_test.go:86: 44.277004792971084 44.277004792971084
rsi_test.go:86: 45.982702307704415 45.982702307704415
rsi_test.go:86: 44.92488376868043 44.924883768680424
rsi_test.go:86: 43.768267110400494 43.768267110400494
rsi_test.go:86: 51.7885329179367 51.7885329179367
rsi_test.go:86: 49.042166759214865 49.04216675921485
rsi_test.go:86: 46.17885754633902 46.178857546339
rsi_test.go:86: 51.11311585011417 51.11311585011415
rsi_test.go:86: 41.128008164891305 41.128008164891305
rsi_test.go:86: 47.133882695775355 47.133882695775355
rsi_test.go:86: 53.558842269084884 53.558842269084884
rsi_test.go:86: 53.677719156865855 53.677719156865855
rsi_test.go:86: 52.804345701181695 52.804345701181695
rsi_test.go:86: 49.34574578714601 49.34574578714601
rsi_test.go:86: 53.824240724248355 53.824240724248355
rsi_test.go:86: 53.43877707811076 53.43877707811076
rsi_test.go:86: 47.24450319236688 47.24450319236688
rsi_test.go:86: 49.18479341136264 49.18479341136264
rsi_test.go:86: 50.61423271473989 50.61423271473989
rsi_test.go:86: 50.614232714739884 50.614232714739884
rsi_test.go:86: 51.44790575424983 51.44790575424983
rsi_test.go:86: 56.0066052594223 56.0066052594223
rsi_test.go:86: 51.7811604211175 51.7811604211175
rsi_test.go:86: 46.81938613254978 46.81938613254978
rsi_test.go:86: 45.33784691804491 45.33784691804491
rsi_test.go:86: 45.823692130119795 45.823692130119795
rsi_test.go:86: 42.11500214933612 42.11500214933612
rsi_test.go:86: 52.24855708462989 52.24855708462989
rsi_test.go:86: 49.97713629285672 49.97713629285672
rsi_test.go:86: 58.05111524271458 58.05111524271458
rsi_test.go:86: 60.81258265615276 60.81258265615276
rsi_test.go:86: 56.620199870314046 56.620199870314046
rsi_test.go:86: 60.715788107812095 60.715788107812095
rsi_test.go:86: 58.989173540428865 58.989173540428865
rsi_test.go:86: 53.39496666304241 53.39496666304241
rsi_test.go:86: 52.0855590825753 52.0855590825753
rsi_test.go:86: 46.279974757075614 46.279974757075614
rsi_test.go:86: 43.46531206180392 43.46531206180392
rsi_test.go:86: 44.96003647943256 44.96003647943256
rsi_test.go:86: 44.292379469223285 44.292379469223285
rsi_test.go:86: 49.16974167856585 49.16974167856585
rsi_test.go:86: 47.27134435321612 47.27134435321612
rsi_test.go:86: 32.55724485497356 32.55724485497356
rsi_test.go:86: 33.62522872456337 33.62522872456337
rsi_test.go:86: 31.269982406486292 31.269982406486292
rsi_test.go:86: 36.17525082033901 36.17525082033901
rsi_test.go:86: 42.91865978528072 42.91865978528072
rsi_test.go:86: 47.52279084366808 47.52279084366808
rsi_test.go:86: 54.925263215422916 54.92526321542292
rsi_test.go:86: 55.6491172486004 55.649117248600405
rsi_test.go:86: 47.123337977706086 47.123337977706086
rsi_test.go:86: 46.72652750314765 46.72652750314765
rsi_test.go:86: 48.13746179051919 48.13746179051919
rsi_test.go:86: 53.10542506163261 53.10542506163261
rsi_test.go:86: 44.412237360898324 44.41223736089832
rsi_test.go:86: 50.95519582110641 50.95519582110641
rsi_test.go:86: 57.62198921999431 57.62198921999431
rsi_test.go:86: 59.98211954189518 59.98211954189517
rsi_test.go:86: 62.284548508784695 62.28454850878469
rsi_test.go:86: 64.4122246125192 64.4122246125192
rsi_test.go:86: 59.973650403526484 59.97365040352648
rsi_test.go:86: 54.592128623349616 54.592128623349616
rsi_test.go:86: 54.35605513519479 54.35605513519479
rsi_test.go:86: 59.158525242513534 59.158525242513534
rsi_test.go:86: 59.74561080619992 59.74561080619992
rsi_test.go:86: 56.13587378573462 56.13587378573462
rsi_test.go:86: 61.10378361342542 61.10378361342542
rsi_test.go:86: 64.23169865173213 64.23169865173213
rsi_test.go:86: 65.33764677636509 65.33764677636509
rsi_test.go:86: 60.91846487295106 60.91846487295106
rsi_test.go:86: 58.14144461591341 58.14144461591341
rsi_test.go:86: 56.34351745609001 56.34351745609001
rsi_test.go:86: 60.629829917154794 60.629829917154794
rsi_test.go:86: 58.44862534452429 58.44862534452429
rsi_test.go:86: 58.502217147973575 58.502217147973575
rsi_test.go:86: 47.75630287639128 47.75630287639128
rsi_test.go:86: 53.39071199497411 53.39071199497411
rsi_test.go:86: 49.49987639274082 49.49987639274084
rsi_test.go:86: 43.668629106530005 43.66862910653001
rsi_test.go:86: 47.08410567765293 47.084105677652936
rsi_test.go:86: 53.47425292984724 53.47425292984724
rsi_test.go:86: 51.65709166975666 51.65709166975666
rsi_test.go:86: 48.13406475870113 48.13406475870113
rsi_test.go:86: 44.5634875774365 44.5634875774365
rsi_test.go:86: 52.87673281423685 52.87673281423685
rsi_test.go:86: 49.13386537769239 49.13386537769239
rsi_test.go:86: 53.526744913097225 53.526744913097225
rsi_test.go:86: 55.40003941176207 55.40003941176207
rsi_test.go:86: 50.54187042968277 50.54187042968277
rsi_test.go:86: 42.187998527943456 42.187998527943456
rsi_test.go:86: 44.371494627757336 44.371494627757336
rsi_test.go:86: 40.53704747325651 40.53704747325651
rsi_test.go:86: 43.83030717971909 43.83030717971909
rsi_test.go:86: 47.274544557614135 47.274544557614135
rsi_test.go:86: 48.458392224920516 48.458392224920516
rsi_test.go:86: 50.01942445978338 50.01942445978338
rsi_test.go:86: 49.75766229621439 49.75766229621439
rsi_test.go:86: 51.61204367429233 51.61204367429233
rsi_test.go:86: 51.89324093739617 51.89324093739617
rsi_test.go:86: 56.66630123268224 56.66630123268224
rsi_test.go:86: 59.97131355988053 59.97131355988053
rsi_test.go:86: 64.62830522892327 64.62830522892327
rsi_test.go:86: 60.98323333742712 60.98323333742712
rsi_test.go:86: 62.931644051651155 62.931644051651155
rsi_test.go:86: 63.49873494220744 63.49873494220744
rsi_test.go:86: 62.31414356497017 62.31414356497017
rsi_test.go:86: 62.56483911581793 62.56483911581793
rsi_test.go:86: 63.40379467170008 63.40379467170008
rsi_test.go:86: 67.86353778710031 67.86353778710031
rsi_test.go:86: 71.11830823557874 71.11830823557874
rsi_test.go:86: 67.92957838565115 67.92957838565115
rsi_test.go:86: 69.53063680317061 69.53063680317061
rsi_test.go:86: 67.47177637189972 67.47177637189972
rsi_test.go:86: 67.26748441372445 67.26748441372445
rsi_test.go:86: 65.34969942807624 65.34969942807624
rsi_test.go:86: 57.85030568475449 57.85030568475449
rsi_test.go:86: 55.85220816100924 55.85220816100924
rsi_test.go:86: 55.29131365670869 55.29131365670869
rsi_test.go:86: 46.70448112293731 46.70448112293731
rsi_test.go:86: 41.408518712087606 41.408518712087606
rsi_test.go:86: 39.19921080273221 39.19921080273222
rsi_test.go:86: 38.46254917960087 38.46254917960087
rsi_test.go:86: 37.63735416132758 37.63735416132758
rsi_test.go:86: 42.16046599492975 42.16046599492976
rsi_test.go:86: 35.48352650149867 35.4835265014987
rsi_test.go:86: 31.303136471359807 31.303136471359807
rsi_test.go:86: 29.121854888479604 29.121854888479604
rsi_test.go:86: 27.24426761600006 27.24426761600006
rsi_test.go:86: 24.28418463313561 24.28418463313561
rsi_test.go:86: 23.417103907545197 23.417103907545197
rsi_test.go:86: 20.322574588973566 20.322574588973566
rsi_test.go:86: 20.06300760276686 20.06300760276686
rsi_test.go:86: 18.879971255877408 18.879971255877408
rsi_test.go:86: 25.354313048557458 25.354313048557458
rsi_test.go:86: 31.06754296943069 31.06754296943069
rsi_test.go:86: 29.15401532944199 29.15401532944199
rsi_test.go:86: 27.988321034946097 27.988321034946097
rsi_test.go:86: 45.53442427378082 45.53442427378082
rsi_test.go:86: 37.821051671680706 37.821051671680706
rsi_test.go:86: 37.34374224244366 37.34374224244366
FAIL
exit status 1
FAIL github.com/MicahParks/go-rsi/v2 0.366s
I print out the result and results[0] by t.Error(result, results[0])
…On Wed, May 15, 2024 at 4:24 PM Micah Parks ***@***.***> wrote:
Would you include the full test output, I don't have access to a Macbook
and am curious to see the output.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCXJFAQVB5B5ROGP2BPINLZCPVCNAVCNFSM6AAAAABHR62PNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJTGY2DIMJTGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
(base) ***@***.*** go-rsi % go test
--- FAIL: TestRSI_Calculate (0.00s)
FAIL
exit status 1
FAIL github.com/MicahParks/go-rsi/v2 0.335s
…On Fri, May 17, 2024 at 1:31 PM Qing Zhou ***@***.***> wrote:
(base) ***@***.*** go-rsi % go test
--- FAIL: TestRSI_Calculate (0.00s)
rsi_test.go:86: 74.05997693194935 74.05997693194935
rsi_test.go:86: 66.85220483413693 66.85220483413693
rsi_test.go:86: 70.13392792714788 70.13392792714788
rsi_test.go:86: 59.4965020993055 59.496502099305495
rsi_test.go:86: 53.847989515796236 53.847989515796236
rsi_test.go:86: 54.31507914768538 54.31507914768538
rsi_test.go:86: 47.70441856222932 47.70441856222932
rsi_test.go:86: 51.88513226122602 51.88513226122602
rsi_test.go:86: 52.23363827029182 52.23363827029182
rsi_test.go:86: 42.115354879279415 42.11535487927941
rsi_test.go:86: 44.80693633023409 44.80693633023408
rsi_test.go:86: 42.84043542606478 42.84043542606477
rsi_test.go:86: 44.277004792971084 44.277004792971084
rsi_test.go:86: 45.982702307704415 45.982702307704415
rsi_test.go:86: 44.92488376868043 44.924883768680424
rsi_test.go:86: 43.768267110400494 43.768267110400494
rsi_test.go:86: 51.7885329179367 51.7885329179367
rsi_test.go:86: 49.042166759214865 49.04216675921485
rsi_test.go:86: 46.17885754633902 46.178857546339
rsi_test.go:86: 51.11311585011417 51.11311585011415
rsi_test.go:86: 41.128008164891305 41.128008164891305
rsi_test.go:86: 47.133882695775355 47.133882695775355
rsi_test.go:86: 53.558842269084884 53.558842269084884
rsi_test.go:86: 53.677719156865855 53.677719156865855
rsi_test.go:86: 52.804345701181695 52.804345701181695
rsi_test.go:86: 49.34574578714601 49.34574578714601
rsi_test.go:86: 53.824240724248355 53.824240724248355
rsi_test.go:86: 53.43877707811076 53.43877707811076
rsi_test.go:86: 47.24450319236688 47.24450319236688
rsi_test.go:86: 49.18479341136264 49.18479341136264
rsi_test.go:86: 50.61423271473989 50.61423271473989
rsi_test.go:86: 50.614232714739884 50.614232714739884
rsi_test.go:86: 51.44790575424983 51.44790575424983
rsi_test.go:86: 56.0066052594223 56.0066052594223
rsi_test.go:86: 51.7811604211175 51.7811604211175
rsi_test.go:86: 46.81938613254978 46.81938613254978
rsi_test.go:86: 45.33784691804491 45.33784691804491
rsi_test.go:86: 45.823692130119795 45.823692130119795
rsi_test.go:86: 42.11500214933612 42.11500214933612
rsi_test.go:86: 52.24855708462989 52.24855708462989
rsi_test.go:86: 49.97713629285672 49.97713629285672
rsi_test.go:86: 58.05111524271458 58.05111524271458
rsi_test.go:86: 60.81258265615276 60.81258265615276
rsi_test.go:86: 56.620199870314046 56.620199870314046
rsi_test.go:86: 60.715788107812095 60.715788107812095
rsi_test.go:86: 58.989173540428865 58.989173540428865
rsi_test.go:86: 53.39496666304241 53.39496666304241
rsi_test.go:86: 52.0855590825753 52.0855590825753
rsi_test.go:86: 46.279974757075614 46.279974757075614
rsi_test.go:86: 43.46531206180392 43.46531206180392
rsi_test.go:86: 44.96003647943256 44.96003647943256
rsi_test.go:86: 44.292379469223285 44.292379469223285
rsi_test.go:86: 49.16974167856585 49.16974167856585
rsi_test.go:86: 47.27134435321612 47.27134435321612
rsi_test.go:86: 32.55724485497356 32.55724485497356
rsi_test.go:86: 33.62522872456337 33.62522872456337
rsi_test.go:86: 31.269982406486292 31.269982406486292
rsi_test.go:86: 36.17525082033901 36.17525082033901
rsi_test.go:86: 42.91865978528072 42.91865978528072
rsi_test.go:86: 47.52279084366808 47.52279084366808
rsi_test.go:86: 54.925263215422916 54.92526321542292
rsi_test.go:86: 55.6491172486004 55.649117248600405
rsi_test.go:86: 47.123337977706086 47.123337977706086
rsi_test.go:86: 46.72652750314765 46.72652750314765
rsi_test.go:86: 48.13746179051919 48.13746179051919
rsi_test.go:86: 53.10542506163261 53.10542506163261
rsi_test.go:86: 44.412237360898324 44.41223736089832
rsi_test.go:86: 50.95519582110641 50.95519582110641
rsi_test.go:86: 57.62198921999431 57.62198921999431
rsi_test.go:86: 59.98211954189518 59.98211954189517
rsi_test.go:86: 62.284548508784695 62.28454850878469
rsi_test.go:86: 64.4122246125192 64.4122246125192
rsi_test.go:86: 59.973650403526484 59.97365040352648
rsi_test.go:86: 54.592128623349616 54.592128623349616
rsi_test.go:86: 54.35605513519479 54.35605513519479
rsi_test.go:86: 59.158525242513534 59.158525242513534
rsi_test.go:86: 59.74561080619992 59.74561080619992
rsi_test.go:86: 56.13587378573462 56.13587378573462
rsi_test.go:86: 61.10378361342542 61.10378361342542
rsi_test.go:86: 64.23169865173213 64.23169865173213
rsi_test.go:86: 65.33764677636509 65.33764677636509
rsi_test.go:86: 60.91846487295106 60.91846487295106
rsi_test.go:86: 58.14144461591341 58.14144461591341
rsi_test.go:86: 56.34351745609001 56.34351745609001
rsi_test.go:86: 60.629829917154794 60.629829917154794
rsi_test.go:86: 58.44862534452429 58.44862534452429
rsi_test.go:86: 58.502217147973575 58.502217147973575
rsi_test.go:86: 47.75630287639128 47.75630287639128
rsi_test.go:86: 53.39071199497411 53.39071199497411
rsi_test.go:86: 49.49987639274082 49.49987639274084
rsi_test.go:86: 43.668629106530005 43.66862910653001
rsi_test.go:86: 47.08410567765293 47.084105677652936
rsi_test.go:86: 53.47425292984724 53.47425292984724
rsi_test.go:86: 51.65709166975666 51.65709166975666
rsi_test.go:86: 48.13406475870113 48.13406475870113
rsi_test.go:86: 44.5634875774365 44.5634875774365
rsi_test.go:86: 52.87673281423685 52.87673281423685
rsi_test.go:86: 49.13386537769239 49.13386537769239
rsi_test.go:86: 53.526744913097225 53.526744913097225
rsi_test.go:86: 55.40003941176207 55.40003941176207
rsi_test.go:86: 50.54187042968277 50.54187042968277
rsi_test.go:86: 42.187998527943456 42.187998527943456
rsi_test.go:86: 44.371494627757336 44.371494627757336
rsi_test.go:86: 40.53704747325651 40.53704747325651
rsi_test.go:86: 43.83030717971909 43.83030717971909
rsi_test.go:86: 47.274544557614135 47.274544557614135
rsi_test.go:86: 48.458392224920516 48.458392224920516
rsi_test.go:86: 50.01942445978338 50.01942445978338
rsi_test.go:86: 49.75766229621439 49.75766229621439
rsi_test.go:86: 51.61204367429233 51.61204367429233
rsi_test.go:86: 51.89324093739617 51.89324093739617
rsi_test.go:86: 56.66630123268224 56.66630123268224
rsi_test.go:86: 59.97131355988053 59.97131355988053
rsi_test.go:86: 64.62830522892327 64.62830522892327
rsi_test.go:86: 60.98323333742712 60.98323333742712
rsi_test.go:86: 62.931644051651155 62.931644051651155
rsi_test.go:86: 63.49873494220744 63.49873494220744
rsi_test.go:86: 62.31414356497017 62.31414356497017
rsi_test.go:86: 62.56483911581793 62.56483911581793
rsi_test.go:86: 63.40379467170008 63.40379467170008
rsi_test.go:86: 67.86353778710031 67.86353778710031
rsi_test.go:86: 71.11830823557874 71.11830823557874
rsi_test.go:86: 67.92957838565115 67.92957838565115
rsi_test.go:86: 69.53063680317061 69.53063680317061
rsi_test.go:86: 67.47177637189972 67.47177637189972
rsi_test.go:86: 67.26748441372445 67.26748441372445
rsi_test.go:86: 65.34969942807624 65.34969942807624
rsi_test.go:86: 57.85030568475449 57.85030568475449
rsi_test.go:86: 55.85220816100924 55.85220816100924
rsi_test.go:86: 55.29131365670869 55.29131365670869
rsi_test.go:86: 46.70448112293731 46.70448112293731
rsi_test.go:86: 41.408518712087606 41.408518712087606
rsi_test.go:86: 39.19921080273221 39.19921080273222
rsi_test.go:86: 38.46254917960087 38.46254917960087
rsi_test.go:86: 37.63735416132758 37.63735416132758
rsi_test.go:86: 42.16046599492975 42.16046599492976
rsi_test.go:86: 35.48352650149867 35.4835265014987
rsi_test.go:86: 31.303136471359807 31.303136471359807
rsi_test.go:86: 29.121854888479604 29.121854888479604
rsi_test.go:86: 27.24426761600006 27.24426761600006
rsi_test.go:86: 24.28418463313561 24.28418463313561
rsi_test.go:86: 23.417103907545197 23.417103907545197
rsi_test.go:86: 20.322574588973566 20.322574588973566
rsi_test.go:86: 20.06300760276686 20.06300760276686
rsi_test.go:86: 18.879971255877408 18.879971255877408
rsi_test.go:86: 25.354313048557458 25.354313048557458
rsi_test.go:86: 31.06754296943069 31.06754296943069
rsi_test.go:86: 29.15401532944199 29.15401532944199
rsi_test.go:86: 27.988321034946097 27.988321034946097
rsi_test.go:86: 45.53442427378082 45.53442427378082
rsi_test.go:86: 37.821051671680706 37.821051671680706
rsi_test.go:86: 37.34374224244366 37.34374224244366
FAIL
exit status 1
FAIL github.com/MicahParks/go-rsi/v2 0.366s
I print out the result and results[0] by t.Error(result, results[0])
On Wed, May 15, 2024 at 4:24 PM Micah Parks ***@***.***>
wrote:
> Would you include the full test output, I don't have access to a Macbook
> and am curious to see the output.
>
> —
> Reply to this email directly, view it on GitHub
> <#1 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGCXJFAQVB5B5ROGP2BPINLZCPVCNAVCNFSM6AAAAABHR62PNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJTGY2DIMJTGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestRSI_Calculate failed because issue with floating point precision.