Skip to content

Commit

Permalink
add rose edit and ancils guidance (#319)
Browse files Browse the repository at this point in the history
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
  • Loading branch information
james-bruten-mo and jennyhickson authored Feb 3, 2025
1 parent 79451cd commit 27c8823
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
4 changes: 4 additions & 0 deletions source/WorkingPractices/approvals.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ off the approval.
code owners is available and they should still be consulted as part of your
development.

.. important::

New UM Ancils must be submitted to the MIAO team for approval. Please follow their process for `Requesting New UM Ancils <https://code.metoffice.gov.uk/trac/ancil/wiki/ANTS/ProjectManagement/updating_UMDIR>`_.

Code Owners
-----------
Every file in the codebases has a :ref:`code_owner`, and every file changed
Expand Down
11 changes: 8 additions & 3 deletions source/WorkingPractices/inputs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Input Variables, Rose Metadata and Upgrade Macros
=================================================

.. important::

New UM Ancils must be submitted to the MIAO team for approval. Please follow their process for `Requesting New UM Ancils <https://code.metoffice.gov.uk/trac/ancil/wiki/ANTS/ProjectManagement/updating_UMDIR>`_.

Sometimes the developer needs to alter model namelists and input variables.
A common reason is for the inclusion of a new piece of code which has to be
turned off by default.
Expand Down Expand Up @@ -73,13 +78,13 @@ to the new metadata. The SSD team are also available to advise on whether an upg
rose edit -C rose-stem/app/APP-NAME
For LFRic Apps a few extra changes are required:
For LFRic Apps a few extra changes are required. In your branch (your test branch if you have an upgrade macro):

.. code-block::
export ROSE_PYTHONPATH=$PYTHONPATH
export ROSE_META_PATH=/path/to/valid/core
rose edit -C rose-stem/app/APP-NAME
export ROSE_META_PATH=/path/to/valid/core:/path/to/apps/copy
rose edit -C rose-stem/app/APP-NAME --no-warn version
This requires an LFRic Core working copy at an appropriate revision to be available. It is also necessary to run from the top level of the Apps working copy to ensure rose metadata paths are valid.

Expand Down

0 comments on commit 27c8823

Please sign in to comment.