-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test warning #292
Fix test warning #292
Conversation
…`pytest tests` at source directory
…ed, as reported by CI pipeline on Github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of the log chatter is probably left over development nonsense however this change does neatly document what exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to recognise this change from a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks familiar although it has new stuff too. Has there been a branching issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another duplicate change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen in a different PR.
Hi Matthew, |
…ith changes in fix_test_errors, with conflicts solved
Hi @MatthewHambley , I have merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready for trunk.
This PR is to fix test warnings, either by changing them to report errors when warnings are not issued if they are designed in fab with intentions through pytest.warns() or by filtering them out if they are related to deprecation warnings in dependent packages with @pytest.mark.filterwarnings(). The motivation of this PR is explained in Issue hiker/fab#5. The fix for test errors is in another PR.
This PR has passed the CI pipeline. It was tested to have no warnings with Python 3.12. However, there are still some Python-version-specific warnings left if you look at the CI pipeline results. The related PR on hiker/fab is here: hiker/fab#10
Depends on