Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Site Layout Editor - Meeds-io/MIPs#175 #335

Merged
merged 53 commits into from
Feb 6, 2025
Merged

Conversation

boubaker
Copy link
Member

@boubaker boubaker commented Feb 4, 2025

boubaker and others added 28 commits February 6, 2025 14:26
…303)

This change will initiate a new porllet to allow site layout edition.
This change will allow to designate the sections to display in a site
layout.
…Ps#175 (#305)

This change will introduce a new Drawer to allow editing Sidebar Section
properties such as background image, max width and apps Text Style.
…s#175 (#306)

This change will allow to customize the Banner Section Properties:
Margin, Background, Visibility and Applications Text Style.
…Ps#175 (#308)

This change will allow to add an application in the context of the site
layout editor.
… (#309)

This change will allow to add an application in a Site Layout by
allowing to adjust its properties and settings.
…s-io/MIPs#175

This change will add a new option to allow aligning applications inside a Banner Container.
)

This change will allow to have internal sections in Site Layout.
#314)

This change will introduce the `Site Pages Properties Drawer` to allow
setting global pages properties.
Prior to this change, the banner section moving wasn't possible due to a
bug in `Draggable` component which doesn't allow to have an empty `slot`
(`#header`) as child component (compute of **visible indices** are wrong
in `Draggable framework`)
Prior to this change, when moving applications to an empty section, the
'Add Application' zone is still displayed. This change hides this zone
and elevate the sections to help diffeciating the existing sections.
…ds-io/MIPs#175 (#318)

This change will allow to have empty Sidebar sections when parsing the
site layout retrieved from frontend.
…319)

This change will implement the new Site Layout Rendering engine which
transfers Site applications rendering from gtmpl files into Vue based
components instead which will allow to have a WYSIWYG effect when
changing application through Layout Editor in addition to the
optimization of Page Rendering performances tod ecouple rendering in
multiple requests instead of a single one.
boubaker and others added 24 commits February 6, 2025 14:26
…s-io/MIPs#175

- Fix Display of Mask When Page is being edited in a different Tab - MEED-8266 - Meeds-io/MIPs#175

- Fix Banner Cell Overflow to be Hidden - MEED-8266 - Meeds-io/MIPs#175

- Fix Layout Editors Page Scrollbar Display - MEED-8266 - Meeds-io/MIPs#175

- Increase Max Margins Value from 20 to 200 - MEED-8266 - Meeds-io/MIPs#175

- Fix puvlished destination site instead of draft one when clicking on 'Publish'

- Fix creating Draft Site by cloning original Site Layout - MEED-8266 - Meeds-io/MIPs#175
Prior to this change, when cloning the original site to a Draft site, the cloning wasn't made correctly since the porlets still referencing the old site. This change will operate a deep cloning to avoid such a behavior on apps.

- Fix Page Object Models Permissions Check

- Fix Sidebar Cell Style and Sidebar Section Menu in Site Layout Editor

- Fix Layout Background Image ACL NPE
In order to allow to reuse the Coediting API in other addons, this
change will move the Coediting API used in Layout Editor into social as
a reusable component.
…EED-8306 - Meeds-io/MIPs175 (#324)

Prior to this change, the Site containers attachment was using the same
container's id '0'. This will lead to delete all containers attachments
when modifying a background for a given container. This change will
allow to make a unique attachment per container.
Meeds-io/MIPs#175 (#325)

Prior to this change, the Sidebar Cell container is adjusted to
applications content only. This change will allow to display the
container in full width height.
… (#326)

Prior to this change, the page background was applied on parent
container where the background has been defined. This change will allow
to define the value of Page Background in the element itself or in the
ancestor elements.
…MIPs#175 (#329)

This change will allow to preview draft changes before saving/publishing
to the real site content.
This change will delete an extra margin added in Sites Management UI due
to a deprecated class used in parent node of portlet.
…s-io/MIPs#175 (#331)

Prior to this change, the CSS Classes of Margins in Site Layout Sections
was computed as it was an application Margin. This change will ensure to
differentiate Section Margins computing from Applications Margin
Computing.
Prior to this change, in order to select an existing system page
template with columns configuration, the content isn't retrieved in
existing templates list, thus it can't choose the adequate basic page
template to use. This change will enforce to retrieve the Page Templates
with its content when needed rather than relying on existing lit.
…/MIPs#175 (#338)

This change will allow to make the Sidebar widths dynamic with a max
width relative to screen resolution.
Prior to this change, when duplicating a site template, the form is displayed as it's about a new Site Template. This change will display the form as it was an edition of an existing Site template for better UX consistency.
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
37.7% Coverage on New Code (required ≥ 60%)
4 New Critical Issues (required ≤ 0)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@boubaker boubaker merged commit d8af2b3 into develop Feb 6, 2025
4 of 5 checks passed
@boubaker boubaker deleted the merge-mip-175 branch February 6, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Layout Editor
2 participants