Fix legacy ruff errors and enable corresponding rules for future linting

[janosh]

follow up to #122.

excludes all the inadvertent changes @ml-evs pointed out in #122 and i went through the rest more carefully this time. so much higher level of confidence that these changes are safe

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 44.94048% with 185 lines in your changes missing coverage. Please review.

Project coverage is 48.80%. Comparing base (189518f) to head (7fa0708).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #134      +/-   ##
===========================================
- Coverage    49.07%   48.80%   -0.27%     
===========================================
  Files           43       43              
  Lines         4950     4944       -6     
  Branches      1039     1056      +17     
===========================================
- Hits          2429     2413      -16     
+ Misses        2280     2278       -2     
- Partials       241      253      +12     

Files	Coverage Δ
src/jobflow_remote/__init__.py	100.00% <ø> (ø)
src/jobflow_remote/cli/__init__.py	100.00% <ø> (ø)
src/jobflow_remote/cli/execution.py	92.30% <ø> (ø)
src/jobflow_remote/cli/jf.py	74.19% <100.00%> (ø)
src/jobflow_remote/cli/jfr_typer.py	95.65% <100.00%> (ø)
src/jobflow_remote/config/settings.py	92.00% <ø> (ø)
src/jobflow_remote/testing/__init__.py	76.59% <100.00%> (-0.49%)	⬇️
src/jobflow_remote/cli/job.py	20.61% <0.00%> (ø)
src/jobflow_remote/cli/types.py	90.19% <0.00%> (ø)
src/jobflow_remote/config/base.py	82.56% <90.90%> (+0.66%)	⬆️
... and 30 more

[ml-evs]

I've given this a once over and nothing looks untoward (just a couple of minor comments), thanks @janosh

[janosh]

fwiw, i think fixing FBT001 FBT002 would be good to do at some point

[gpetretto]

Hi @janosh, thanks for opening this PR and addressing the issues raised previously by @ml-evs.
From a quick look it seems indeed that there are not many changes affecting the code, but since this has a large impact on the code base my plan would be:

• merge Small updates to JobController and CLI #132 and Bump psutil from 5.9.8 to 6.0.0 #127
• make a new release (as we it need relatively quickly).
• take a bit of time to look at this PR in detail.

I will do this in the next days.

[janosh]

sounds good, will resolve the merge conflicts here.

i was going to take a swing at addressing #124 once this PR is merged (to avoid further conflicts)

[janosh]

@gpetretto bump

[gpetretto]

Hi @janosh, sorry, I had already done my review, but forgot to finally publish it. I just have one question and one bug fix that was already there and could be fixed directly here.

[gpetretto]

Thanks!