-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test RST rendering on GitHub #493
Conversation
This one does render properly. So do some more complex rst files on other repos, e.g. https://github.com/rstcheck/rstcheck/blob/main/README.rst. |
Hmmm yeah, trying to pin down which version stops rendering for us (it still seems like a recent change). If this is a rendering timeout issue, maybe this is a good excuse to cut down the complexity of the specification with @rartino's properties... |
Probably the same thing; rich diffs for PRs against optimade.rst now gives the error:
|
Old versions like https://github.com/Materials-Consortia/OPTIMADE/blob/6f1e115094ec256c262df712a35c86f4d3e6d1c7/optimade.rst fail to render when they definitely used to (Firefox Developer Edition, no extensions) |
Will close this to not pollute PRs, we can continue discussing at #492 |
Okay, the first 312 lines of the spec render... https://github.com/Materials-Consortia/OPTIMADE/blob/3ba8299979001f0cfdd02bde55d241a9b2a3d9d3/optimade.rst |
Maybe a sign that it is time to split it into separate files?... |
And there's no issue using custom roles/toc (in isolation, at least, could still be added complexity once the file is too large) |
Sure, but for now we still won't have enough space to describe what's in those files (assuming you mean properties at least!) |
I mean chopping it up into chapters (and re-merge when rendering). It is a bit finky with the TOC, will require some non-trivial infrastructure work. |
Sure, if each individual .rst can still be previewed fine. I still have https://ml-evs.science/OPTIMADE/optimade.html going, could also put some work into making this multi-versioned and deployed sensibly, as the "real" specification for users to view. |
@@ -913,3 +913,82 @@ An example of a full response: | |||
|
|||
If the server is able to handle serialization in such a way that it can dictate the order of the top level object members in the response, it is RECOMMENDED to put the :field:`jsonapi` as the first top level member to simplify identification of the response. | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a yardstick, addition of this patch (b177978) is what breaks rendering (as of today). I'll try to see if there's any weird feature we're using here that is causing it to lag
ae88af9
to
d82b3cb
Compare
Since the spec becomes a standalone HTML document, not necessary connected to a GitHub-org, let's later add the "Community" section to the Appendix, so that the reader might get some idea about the Optimade people without googling. |
See #492