Add MHKiT-Python v0.9.0 Support #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
High level this is a byproduct of MHKiT-Python switching to xarray. I am not exactly sure of the root cause, but the difference is that that the modified MHKiT-Python functions return singular dimension DataFrames that need to be accessed without using `.values`
Updating to newer versions of MATLAB and Python to see if any test results change.
This attempts to fix:
```
/opt/hostedtoolcache/MATLAB/2022.2.999/x64/interprocess/bin/glnxa64/pycli/../../../../sys/os/glnxa64/libstdc++.so.6:
version `GLIBCXX_3.4.29' not found (required by
/home/runner/miniconda3/envs/mhkit_conda_env/lib/python3.10/site-packages/scipy/optimize/_highs/_highs_wrapper.cpython-310-x86_64-linux-gnu.so)
```
By updating the MATLAB version.
Removed in MHKiT Python v0.8.0 and above
This seems to determine how stable MATLAB is and using an older version is advantageous for compatibility. This increase is specifically for Python 3.12.
One test fails with 1.11.4:
macos-13, Python 3.12, MATLAB R2024b
```
../Users/runner/miniconda3/envs/mhkit_conda_env/lib/python3.12/site-packages/scipy/__init__.py:132: UserWarning: A NumPy version >=1.21.6 and <1.28.0 is required for this version of SciPy (detected version 2.2.2)
warnings.warn(f"A NumPy version >={np_minversion} and <{np_maxversion}"
```
Attempt to silence: ``` C:\Users\runneradmin\miniconda3\Lib\site-packages\conda\base\context.py:201: FutureWarning: Adding 'defaults' to channel list implicitly is deprecated and will be removed in 25.3. To remove this warning, please choose a default channel explicitly with conda's regular configuration system, e.g. by adding 'defaults' to the list of channels: conda config --add channels defaults For more information see https://docs.conda.io/projects/conda/en/stable/user-guide/configuration/use-condarc.html deprecated.topic( ```
|
Initial test failure summary: Failure Summary (Windows cache population job): |
Fails with this error:
```
Error using _cythonized_array_utils>init
scipy.linalg._cythonized_array_utils (line 1)
Python Error: ValueError: numpy.dtype size changed, may indicate binary
incompatibility. Expected 96 from C header, got 88 from PyObject
```
Same test works on ubuntu. Likely related to scipy version
|
Current Windows Population Job Test Summary: |
|
@rpauly18, this PR is ready for review. This PR implements Python/Matlab type conversions that will unblock progress on the live scripts documentation (#110). Failed tests for follow-up PR:
Note: This PR touches multiple core modules requiring a merge commit. Recommend merging #151 first to avoid conflicts with the upcrossing module. |
This was referenced Feb 3, 2025
rpauly18
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for MHKiT-Python 0.9.0
Major Changes
Version Compatibility Updates
Standardization of Type Conversions
This represents the initial implementation of standardized type conversion handling. Additional type
conversions will be implemented where necessary. Type conversion was heavily utilized in the wave
module to standardize xArray to Pandas output across different return types.
Note: At this time not all functions require changes to MHKiT-Python output type conversion. Only
functions that required standardized type conversion were changed in this PR
Currently implemented conversions:
Test Suite Modernization
Outstanding Test Issues (
assumeFail)Note: Resolving these test failures is considered outside the scope of this PR as they require deeper investigation into underlying implementation differences between MHKiT-Python versions.
The following tests require further investigation and are currently marked as
assumeFail:test_surface_elevation_seed123, which has been modifiedtest_surface_elevation_phasingtest_mler_coefficientsmler_coefficientstest_bin_statistics