Stk 2 - refactor Album page: 1 component for display, one for actions #3048
+1,470
−998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
added
the
Review: hard
ildyria
changed the title
ildyria
force-pushed
the
album-panel-display-from-logic
branch
from
6a67609 to
d660978
Compare
ildyria
force-pushed
the
no-more-photo-page
branch
from
293bbba to
abaacc6
Compare
ildyria
force-pushed
the
album-panel-display-from-logic
branch
from
d660978 to
3197811
Compare
ildyria
force-pushed
the
no-more-photo-page
branch
from
abaacc6 to
2459c9c
Compare
ildyria
force-pushed
the
no-more-photo-page
branch
from
2459c9c to
7533f3e
Compare
ildyria
force-pushed
the
album-panel-display-from-logic
branch
from
3197811 to
d70dd01
Compare
|
I would be happy if the changes in the frontend are also available soon |
ppshobi
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big refactoring getting rid of the photo page and instead displaying a Photo overlay on top of the Album/Search.
Also reduce the number of results in the search.
This pull request includes changes to improve the handling of album IDs, reduce the search pagination limit, and update multiple language files by removing the "searching" text.
Key changes:
Improvements to album handling:
app/Http/Controllers/VueController.php: Modified theviewfunction to handle album IDs more effectively by checking if thealbumIdis not 'all'.Database migration:
database/migrations/2025_03_01_154728_search_pagination_limit_reduction.php: Added a migration to reduce the search pagination limit from 1000 to 300 to reduce the load on the front-end.Language file updates:
lang/cz/gallery.php,lang/de/gallery.php,lang/el/gallery.php,lang/en/gallery.php,lang/es/gallery.php,lang/fr/gallery.php,lang/hu/gallery.php,lang/it/gallery.php,lang/ja/gallery.php,lang/nl/gallery.php,lang/no/gallery.php,lang/pl/gallery.php,lang/pt/gallery.php,lang/ru/gallery.php,lang/sk/gallery.php,lang/sv/gallery.php,lang/vi/gallery.php,lang/zh_CN/gallery.php: Removed the "searching" text from the search section in multiple language files. [1] [2]