-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation steps for Tailwind CSS v4.0 & Linux environments #157
base: main
Are you sure you want to change the base?
Add installation steps for Tailwind CSS v4.0 & Linux environments #157
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@desmondinho been able to work on this a little today, however it seems I cannot get the title from the I expected them to be bold and have some breathing room around them, but nope. Can you see anything in the code I might've missed perhaps? If not I will find a different solution. |
Thank you very much for starting this PR!
Yes, the reason behind it is that these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it ❤️
Btw, I am almost done with the new LumexTab
component that we could actually use on this page to make it a bit more compact. I think that I will it this weekend.
docs/LumexUI.Docs.Client/Components/Layouts/InstallationLayout.razor
Outdated
Show resolved
Hide resolved
docs/LumexUI.Docs.Client/Components/Layouts/InstallationLayout.razor
Outdated
Show resolved
Hide resolved
Ah, got it. I have found an easy workaround, those section titles should now display correctly.
Nice! Then I guess we should wait for this shiny new component to be available to complete this PR, no? |
Great!
Yes, I’ll keep you updated! |
Hey @aurepereira, I’ve had some more time to think about this, and I’ve concluded that it might not be the best time to introduce a full-fledged installation process with Tailwind CSS v4. Here’s why:
For now, I think the best approach would be to:
What do you think about this plan? |
@desmondinho yeah man that totally works for me, that is a very valid point. Let's shelve this PR for now, I just opened a smaller one adding just the changes you suggested: #160 Let me know if the wording isn't to your liking, in the meantime I will also reference this conversation in #156 |
Description
Closes #156
What's been done?
Added a callout in the Installation section warning to users to select the correct version of Tailwind CSS they plan on using. Users can navigate to the correct section by clicking on the appropriate link
Added installation steps in the documentation to use Tailwind CSS v4.0. These instructions are displayed along with the original installation instructions, which are now labeled
Instructions for Tailwind CSS v3.*
Added extra steps in the documentation to download and start Tailwind CSS as part of the build, for both Windows and Linux environments
Checklist
Additional Notes