Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TR2R sprite issues #761

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix TR2R sprite issues #761

merged 2 commits into from
Aug 23, 2024

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Aug 23, 2024

Resolves #760.

Checklist

Description

  • TR2R seems to need 0 for the brightest shade, whereas classic uses -1.
  • The TRGE update takes care of injecting the weapons into Floater and Lair, the same way it does for classic. It was being skipped as it's all handled a little differently there.

@lahm86 lahm86 added bug Something isn't working TRR labels Aug 23, 2024
@lahm86 lahm86 added this to the 1.10.0 milestone Aug 23, 2024
@lahm86 lahm86 self-assigned this Aug 23, 2024
@lahm86 lahm86 requested review from rr-, chreden and makotocchi August 23, 2024 20:01
@lahm86 lahm86 merged commit f790830 into LostArtefacts:master Aug 23, 2024
2 checks passed
@lahm86 lahm86 deleted the issue-760-trr-pickup-sprites branch August 23, 2024 21:28
@lahm86 lahm86 modified the milestones: 1.10.0, 1.9.3 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chreden chreden chreden approved these changes

@rr- rr- Awaiting requested review from rr-

@makotocchi makotocchi Awaiting requested review from makotocchi

Assignees

@lahm86 lahm86

Labels
bug Something isn't working TRR
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.

Sprite issues in TR2R OG graphics
2 participants
@lahm86 @chreden