Add TRR secret support #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the duplicated trigger logic for TR1/3 secrets into a shared class, will be re-used for remasters.
Shared logic for TR1 separated out.
Shared logic for TR2 separated out. Reward randomization not possible (no accessible gameflow).
Shared logic for TR3 separated out.
rr-
approved these changes
May 21, 2024
chreden
approved these changes
May 21, 2024
lahm86
added a commit
to lahm86/TR-Rando
that referenced
this pull request
May 30, 2024
Regression from LostArtefacts#681.
lahm86
added a commit
to lahm86/TR-Rando
that referenced
this pull request
May 30, 2024
Regression from LostArtefacts#681.
lahm86
added a commit
to lahm86/TR-Rando
that referenced
this pull request
May 30, 2024
Regression from LostArtefacts#681.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #614.
Checklist
Description
Secret randomization is now supported in TRR, and reward randomization for TR1 and TR3. We can't access the gameflow so TR2 rewards remain OG.
I've moved a lot of things around, mainly sharing out logic where possible. For example TR1, TR1R, TR3 and TR3R all use the same logic for placing secret triggers now. Some things remain duplicated between the classic and remasters, but once we get rid of the threaded approach (#569) for the heavy-lifter classes I'll re-address this and try to streamline it further.
The PDP/MAP cache classes will be built upon for enemy randomization later, so for TR2 there is no class yet as no model switching required there for secrets.