Expand on TRR file control #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
approved these changes
May 20, 2024
| ["PLAYER_2"] = TR3Type.CutsceneActor2, | ||
| ["PLAYER_3"] = TR3Type.CutsceneActor3, | ||
| ["PLAYER4"] = TR3Type.CutsceneActor4, | ||
| ["PLAYER_4"] = TR3Type.CutsceneActor_4, |
There was a problem hiding this comment.
There seems to be a duplicate of sorts in the map files for TR3, with PLAYER4 and PLAYER_4. Because we need unique keys for the flipped version of the dictionary, I just added the new placeholder type. It's not something we'll be changing to be honest, it's mainly just to prove we can match everything up for the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #614.
Checklist
Description
Some further progress in reading/writing TRR files.
MAPandPDPare what we'll need for the most part for moving models around, so these are now part of the three combined level classes. Nothing uses these yet, this is just the groundwork. I've also added (local) tests for the TRR level files in case anything changes there.The large alias enums are needed so we know after import how to map object IDs. That'll probably be managed in
TRDataControlat some point. The string to enum maps are also needed to avoid us renamingTR1Type,TR2Type,TR3Typeto match the names in theMAPfiles, as that would cause too many rewrites elsewhere.Moving the additional files around is all handled by TRGE, just like the script and suchlike currently.
TRGandTEXfiles are also backed up, but we don't currently use them (or rather know the format).