Refactor room-related collections #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All levels store a uint before the room count which is always 0 and is ignored in all games during read, It is believed to be a level number field. We store this for 1-3 in case it becomes usable, TR4/5 is a little more awkward because of where it's kept in the compressed part of the file, so for now we just keep it in place.
TRGE updates room flags when the sunset is enabled.
rr-
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #468.
Checklist
Description
Further work on converting arrays to lists, mainly things related to rooms this time. The sub structures are still quite array-heavy, like
TRRoombut we will get to those separately as they're also heavily referenced elsewhere.The next - and hopefully final - stage for the top level variables will be meshes, the remaining texture data and sound effects and then we can look at data re-organisation.