Standardize const usage #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the repeated redefinitions of 1024/1023 with TRConsts.Step4. Replaced the repeated redefinitions of 768 with TRConsts.Step3. Replaced the repeated redefinitions of 512 with TRConsts.Step2. Replaced the repeated redefinitions of 256 with TRConsts.Step1.
Replaced redefinitions of 255 with TRConsts.NoRoom.
Replaced redefinitions of -127 with TRConsts.WallClicks.
Replaced redefinitions of 256 for textiles with relevant width, height and size consts.
IsWall is much clearer and easier to pronounce :)
rr-
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #575.
Checklist
Description
Some housekeeping to align const usage throughout the codebase by removing repeated definitions and hardcoded values.
I've also updated a couple of NuGet packages (test framework and common drawing), and cleared compiler noise, which appeared after the latest Visual Studio update.