Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html): support collapsed attribute in blockquote tag #308

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

AndrielFR
Copy link
Contributor

@AndrielFR AndrielFR commented Jan 26, 2025

With this, now we can use:

InputMessage::html("<blockquote expandable>Lorem ip...</blockquote>")

- Added logic to check for the 'collapsed' attribute in blockquote tags.
- Updated MessageEntityBlockquote to use the collapsed attribute value.
@AndrielFR
Copy link
Contributor Author

As for markdown equivalent, i don't what to use.

@Lonami
Copy link
Owner

Lonami commented Jan 26, 2025

I don't think this is standard HTML right? So I worry about discoverability.

@AndrielFR
Copy link
Contributor Author

AndrielFR commented Jan 26, 2025

I don't think this is standard HTML right? So I worry about discoverability.

No, i haven't found an equivalent on HTML

@AndrielFR
Copy link
Contributor Author

I don't think this is standard HTML right? So I worry about discoverability.

No, i haven't found an equivalent on HTML

Ok, bot api uses expandable in HTML.
Ref: https://core.telegram.org/bots/api#html-style

As for markdown version, it uses:

**> ...
> ...
> ...||

Ref: https://core.telegram.org/bots/api#markdownv2-style

@Lonami
Copy link
Owner

Lonami commented Jan 26, 2025

While neither are standard, I think it's worthwhile being consistent, for discoverability purposes.

@AndrielFR
Copy link
Contributor Author

While neither are standard, I think it's worthwhile being consistent, for discoverability purposes.

Ok, so i'll follow bot api

@Lonami Lonami merged commit daf8189 into Lonami:master Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants