Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Reth datadir snapshots #59

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

matjazv
Copy link

@matjazv matjazv commented Feb 6, 2025

What was the problem?

  • This PR resolves #LISK-1684.
  • This PR resolves #LISK-1395.

How was it solved?

  • New script for downloading and applying Reth datadir snapshot was developed
  • Existing script for Geth client was modified to use a new filename schema and has a fallback to a previous one
  • Docs was updated where applicable
  • README includes references to the API documentation for the Beacon/Execution clients

How was it tested?

  • Test Reth datadir snapshot was uploaded to S3
  • Following commands were used to test both Geth and Reth clients:
    • APPLY_SNAPSHOT=true CLIENT=geth SNAPSHOT_TYPE=datadir docker compose up --build --detach
    • APPLY_SNAPSHOT=true CLIENT=reth SNAPSHOT_TYPE=datadir docker compose up --build --detach

@matjazv matjazv self-assigned this Feb 6, 2025
.env.mainnet Outdated Show resolved Hide resolved
.env.sepolia Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
reth/download-apply-snapshot.sh Outdated Show resolved Hide resolved
geth/download-apply-snapshot.sh Outdated Show resolved Hide resolved
reth/download-apply-snapshot.sh Outdated Show resolved Hide resolved
geth/download-apply-snapshot.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
geth/download-apply-snapshot.sh Outdated Show resolved Hide resolved
reth/download-apply-snapshot.sh Outdated Show resolved Hide resolved
reth/download-apply-snapshot.sh Outdated Show resolved Hide resolved
Copy link
Member

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for all the changes! 🙏

@sameersubudhi sameersubudhi enabled auto-merge (squash) February 6, 2025 14:27
@sameersubudhi sameersubudhi merged commit 38b2b4d into main Feb 6, 2025
4 checks passed
@sameersubudhi sameersubudhi deleted the LISK-1407-Setup-snapshot-automation branch February 6, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants