feat: Migrate from substrate to polkadot-sdk repo + Implement genesis builder #313
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #313 +/- ##
===========================================
+ Coverage 78.51% 78.69% +0.18%
===========================================
Files 159 165 +6
Lines 10500 10774 +274
===========================================
+ Hits 8244 8479 +235
- Misses 1895 1921 +26
- Partials 361 374 +13 ☔ View full report in Codecov by Sentry. |
| continue | ||
| } | ||
|
|
||
| if err := genesisBuilder.BuildConfig(gcDecodedBytes); err != nil { |
There was a problem hiding this comment.
I see that we unmarshal the decoded bytes every time in each module. Thoughts on unmarshalling only once here, and pass the struct to the modules?
There was a problem hiding this comment.
I was thinking about it, but I'm not sure if that's achievable without predefining all available genesis configs. I think we should keep it dynamic, especially for when we start supporting custom pallets. Let me know if you have any ideas
|
Can we update the |
| continue | ||
| } | ||
|
|
||
| if err := genesisBuilder.BuildConfig(gcDecodedBytes); err != nil { |
There was a problem hiding this comment.
Every module configuration must be included in the bytes. Currently, you can execute the function without having balances
Detailed description:
Which issue(s) this PR fixes:
Fixes #241
Special notes for your reviewer:
Checklist