Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(AccountId): underlying representation to be Address32 #305

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented Nov 27, 2023

Detailed description:

Which issue(s) this PR fixes:
Fixes #300

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@failfmi failfmi self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f4937b4) 78.08% compared to head (557209b) 78.25%.

❗ Current head 557209b differs from pull request most recent head d762866. Consider uploading reports for the commit d762866 to get more accurate results

Files Patch % Lines
primitives/types/lookup.go 70.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #305      +/-   ##
===========================================
+ Coverage    78.08%   78.25%   +0.16%     
===========================================
  Files          157      157              
  Lines        10431    10424       -7     
===========================================
+ Hits          8145     8157      +12     
+ Misses        1914     1899      -15     
+ Partials       372      368       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@failfmi failfmi marked this pull request as ready for review November 27, 2023 17:39
@failfmi failfmi linked an issue Nov 27, 2023 that may be closed by this pull request
nicksinch
nicksinch previously approved these changes Nov 28, 2023
radkomih
radkomih previously approved these changes Nov 29, 2023
primitives/types/multi_address.go Outdated Show resolved Hide resolved
@failfmi failfmi dismissed stale reviews from radkomih and nicksinch via d762866 November 29, 2023 13:46
@failfmi failfmi requested a review from radkomih November 29, 2023 13:47
@failfmi failfmi merged commit e890e7b into develop Nov 29, 2023
@failfmi failfmi deleted the refactor/account-id branch November 29, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor AccountID
3 participants