Skip to content

Commit

Permalink
Fix Ragger for cross repo tests
Browse files Browse the repository at this point in the history
  • Loading branch information
fbeutin-ledger committed Jul 11, 2024
1 parent 5f309fe commit 53cc7f9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
9 changes: 7 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,15 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.20.3] - 2024-07-11
## [1.20.4] - 2024-07-11

### Fixed
- conftest: Fixed '--device all': limit the tests to devices declared in the App manifest
- conftest: Fixed conftest for cross repository workflows

## [1.20.3] - 2024-07-11

### Added:
- conftest: Limit the tests to devices declared in the App manifest

## [1.20.2] - 2024-07-02

Expand Down
5 changes: 4 additions & 1 deletion src/ragger/conftest/base_conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def additional_speculos_arguments() -> List[str]:


# Glue to call every test that depends on the firmware once for each required firmware
def pytest_generate_tests(metafunc):
def pytest_generate_tests(metafunc, root_pytest_dir: Path):
if "firmware" in metafunc.fixturenames:
fw_list = []
ids = []
Expand All @@ -116,6 +116,9 @@ def pytest_generate_tests(metafunc):
backend_name = metafunc.config.getoption("backend")

# Get supported devices list from manifest
project_root_dir = find_project_root_dir(root_pytest_dir)
manifest = Manifest.from_path(project_root_dir / "ledger_app.toml")

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'manifest' is unnecessary as it is
redefined
before this value is used.

manifest = Manifest.from_path(
Path(metafunc.config.rootpath).parent.resolve() / "ledger_app.toml")
dev_list = ["nanosp" if d == "nanos+" else d for d in manifest.app.devices.json]
Expand Down

0 comments on commit 53cc7f9

Please sign in to comment.