-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bot] Fast-forward for 23.11.4 #491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailserver updated Postfix to 3.6 (#469) * Updating postfix configuration for newer version * Adding log file to postfix * Fixing problems with postfix * Updating MSSQL to use new driver * Adding variable for printable URL This adds a variable used to generate the URL for sending emails. * Revert "Updating MSSQL to use new driver" This reverts commit 092d9ad. * Adding variable to compose and production yaml files * Adding ; to the end of line * Adding one more file * Typo to the netrc file * Removing tls for sending email via Labkey * Removing supervisord from docker file
* Created a query for matching dam and sire suffixes. Added qview.xml, sql, and query.xml files. * Added URL query when clicking on Dam or Sire. Updated SQL query to filter by only Rhesus. * Created four validationSuite queries for checking the rh and suffix of dams, sires, and ids. * Saving test alert. * Created a test email notification. * Added SMTP to test alert. * Enabled a secondary water monitoring notification to test with new method. * Created the NotificationToolkit and used it to create ValidationSuiteNotification.java. Updated WNPRC_EHRModule.java with the new notification. * This is the NotificationTookit basics. More functions will be added to this file as notifications are updated via the revamp. * Added ValidationSuite notification for testing. * Added notification validationSuiteSuffixCheckerRhesusDamSire qview for testing. Need to add qviews for the other 3 suffix checkers if this works. * Undid changes to queries. * Added fully working 'Validation Suite' notification. * Added DeathNotification and AnimalRequestNotification, added 2 necropsy qviews, updated ValidationSuiteNotification and NotificationToolkit. Also moved the deaths and prenatal trigger scripts to the correct location. On wnprc_triggers, I muted the code loading the incorrectly placed deaths and prenatal scripts. * Fixed a function in NotificationToolkit, then fixed it's uses in other files. Also added 2 automated tests to check the prenatal notification and death notification. * Corrected a few typos on WNPRC_EHRTest.java * Updated sendDeathNotification in TriggerScriptHelper. Registered new revamp notification in WNPRC_EHRModule. Reverted DeathNotification.java back to original version. Added DeathNotificationRevamp as separate revamped version. * Added console logs to notify when onComplete executes for incorrectly placed files: PrenatalDeaths.js and Deaths.js and correctly placed files: prenatal.js and deaths.js. Fixed wnprc_ehr/TriggerScriptHelper.java so it sends both death notifications: original and revamped correctly. Updated NotificationToolkit's getTableRowAsList so it checks for an empty table before executing. Updated NotificationTooolkit's getSexFromAnimalID function so it gets sex of prenatal ids as well. Added dam/sire/conception to prenatal notification. Added placeholders for empty data in the notifications. Still need to fix issue with automated test. * Updated category for ValidationSuiteNotification. Restored original AnimalRequestNotification and added revamped version as AnimalRequestNotificationRevamp, revamped version also fixes error with the URL in the original version. Updated TriggerScriptHelper.java calls to send animal request notification with check to verify notification service is active and specific notification is enabled. Still need to write automated tests for AnimalRequestNotificationRevamp. * Unmuted 2 automated test functions: uploadBillingDataAndVerify and updateEHRFormFrameworkTypes. * Updated automated tests to call DeathNotificationRevamp instead of DeathNotification after renaming. * Made changes suggested by the pull request comments.
* Updating postfix configuration for newer version * Adding log file to postfix * Fixing problems with postfix * Updating MSSQL to use new driver * Adding variable for printable URL This adds a variable used to generate the URL for sending emails. * Revert "Updating MSSQL to use new driver" This reverts commit 092d9ad. * Adding variable to compose and production yaml files * Adding ; to the end of line * Adding one more file * Typo to the netrc file * Removing tls for sending email via Labkey * Removing supervisord from docker file * Fixing problem with DNS from the postfix container * Updating nginx and using secrets to access certs * Using variable in the nginx configuration * change extension of compose file
* Use current time for delete source, to always delete, update ETL timestamp column to fix null pointer * Update jdbc driver for arrow connection
cnathe
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
View all PRs: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=23.11_ff_bot_23.11.4