await select in edit mode #2114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-chrisj
requested review from
labkey-danield
and removed request for
a team
|
ERROR: Branch doesn't match LabKey naming scheme: |
labkey-danield
approved these changes
Oct 28, 2024
|
Unfortunately, this PR's remote branch didn't match TeamCity's naming pattern and thus didn't get a build check (which is required). So, deleting this branch, pushing the same change to a branch that will get a build check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Recently, BiologicsSampleTimelineTest.testEditSampleDetailCausesTimelineEvent has failed in 24.7 because the 'status' select was not found (but was present in the after-failure screenshot) when the test attempted to edit a sample's status in order to verify that doing so would cause a timeline event.
This change backports the fix for this intermittent failure from develop; the test will now await the select as it does in develop
Related Pull Requests
n/a
Changes
one-line backport from develop