Test components for biologics cross-folder input form actions tests #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-chrisj
changed the title
labkey-danield
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This adds components to support test coverage of cross-folder form-based data inputs in Biologics.
It's possible both of these components belong in biologics but I'm starting them out here because they might be shared at some point
Also, they probably belong in different locations- they're in the best places I could figure out, given the context. @labkey-tchad , probably this is your bailiwick
SelectInputOptionis useful for scraping row data out of reactSelect options that put lots of metadata into them- this format is definitely used in component selectors in biologics registry, not sure if this data format is universal or if these select-items are formatted on an ad-hoc basis @labkey-nicka , @labkey-alan, thoughts?The Modal dialog, when submitted, calls the '
doAndWaitForUpdate' method implemented on the component getting itRelated Pull Requests
https://github.com/LabKey/biologics/pull/2704
Changes