Improve command-line argument for extracting resources #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could also use |
labkey-tchad
approved these changes
Feb 19, 2024
Comment on lines
67
to
70
| // if (!foundDistributionZip) | ||
| // { | ||
| // throw new ConfigException("Unable to find distribution zip required to run LabKey Server."); | ||
| // } |
There was a problem hiding this comment.
Did you mean to make this non-fatal? I presume this is commented out for local testing?
There was a problem hiding this comment.
Indeed, it was to work on my local dev build. I restored it, though we can revisit as we decide exactly how/when to extract resources in upgrade scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
-extractis a clearer description of what this option does