Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbDisc: Plate Templates (Part 1) #5467

Merged
merged 16 commits into from
May 2, 2024
Merged

AbDisc: Plate Templates (Part 1) #5467

merged 16 commits into from
May 2, 2024

Conversation

labkey-nicka
Copy link
Contributor

@labkey-nicka labkey-nicka commented Apr 30, 2024

Rationale

See https://github.com/LabKey/labkey-ui-premium/pull/400 for primary rationale. The "Plate Templates" support of plates in LKS has been re-labeled as "Plates". The plate listing page will now only show non-standard assay type plates and only supports creation of non-standard assay type plates.

Related Pull Requests

Changes

  • Schema upgrade to add templates bit to plate sets and plates and archive to plates.
  • Update schema XML accordingly.
  • Use ServiceRegistry pattern for AssayPlateMetadataService. Refactor usages.
  • Update createAndSavePlate() to take a Plate instead of a bunch of properties.
  • Extract saveWellData method from createAndSavePlate() for slightly better incapsulation.
  • Remove copyPlate() from the PlateService as this is not needed externally.
  • New PlateManager.copyPlate() method that fully hydrates and persists a copy of a plate or plate template.
  • Rename PlateManager.copyPlate() to PlateManager.copyPlateDeprecated() in favor of new copyPlate() method.
  • Add capability to clear plate cache for an arbitrary set of plate rowIds.
  • Refactor archivePlateSets() to archive() which now handles archive/restore of plates and plate sets.

@labkey-nicka labkey-nicka self-assigned this Apr 30, 2024
@labkey-nicka labkey-nicka merged commit 0981d1e into develop May 2, 2024
5 of 6 checks passed
@labkey-nicka labkey-nicka deleted the fb_plate_template branch May 2, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants