23.11 fb eiacuc to prime end date #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ERROR: A pull request from WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
jonesgaohsu
changed the title
This code done in a pairing session with Gary and Brent.
…nto 23.11_fb_eIACUCtoPrimeEndDate # Conflicts: # onprc_ehr/resources/schemas/dbscripts/sqlserver/onprc_ehr-24.004-24.005.sql
…proved Protocols are enddated
COrrected Misspelled field name at line 44
brentlogan
requested changes
Dec 28, 2024
There was a problem hiding this comment.
- eIACUCtoPrimteProtocols.xml has a typo in its title.
- onprc_ehr-24.004-24.005.sql should not include the withdrawn protocol state in CTE ApprovedProtocols. We are interested in only those protocols that have ever been in the approved state. This code still works, though, as none of the withdrawn protocols has a non-NULL approval_date.
kollil
approved these changes
Dec 30, 2024
Removeed withdrawn from the query where clause
|
requested changes have been made, would like to deploy next week once review is completed |
brentlogan
requested changes
Jan 14, 2025
…CTEs for Stnadarization
|
All changes have been made and awaiting final approval |
|
Tested on UX Text and good results, Moving for deploy to Production tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We want to use eIACUC2 data (the source of truth for protocols) to keep
ehr.protocolautomatically updated. We see at least three steps in this process:ehr.protocolhas a non-NULLenddatewhere the most recent ever-approved protocol per base protocol family is not currently approved.ehr.protocolhas only one record per base protocol family, using the base protocol's protocol_ID and the most recently approved protocol's other data.approval_datePROTOCOL_stateis one of approved, terminated, or expiredehr.protocolwhen eIACUC2 has a more recent approved protocol for a base protocol family.ehr.protocolwhen eIACUC2 data has a new protocol that is not a renewal.This pull request addresses only the first step.
Related Pull Requests
Changes
BaseProtocol,RevisionNumber, andNewestRecordfields to existing tableonpre_ehr.eIACUC_PRIME_VIEW_PROTOCOLS.ehr.protocol.