Improve-cross project actions - Edit in Bulk #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and Edit in Bulk scenarios
… it exists in originalData
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
…ected row(s) - for BulkUpdateForm, disable lookup fields toggle when more than one containerPath in selection
…ws or saveRowsByContainer
…nerPath in selection
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
XingY
requested changes
Apr 26, 2024
packages/components/src/internal/components/editable/LookupCell.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/internal/components/forms/BulkUpdateForm.tsx
Outdated
Show resolved
Hide resolved
| helpTipRenderer, | ||
| }} | ||
| showLabel={showLabel} | ||
| showToggle={allowDisable} | ||
| isDisabled={isDisabled} | ||
| toggleProps={{ | ||
| onClick: this.toggleDisabled, | ||
| onClick: toggleDisabledTooltip ? undefined : this.onToggleChange, |
There was a problem hiding this comment.
What about lookup fields with fix container col.lookup?.containerPath and App.isAllProductFoldersFilteringEnabled() ?
There was a problem hiding this comment.
ah yes, good call. fix added so that we don't disable the bulk form lookup if there is a col.lookup.containerPath defined (this was changed in QueryFormInputs.tsx where toggleDisabledTooltip is set).
There was a problem hiding this comment.
and App.isAllProductFoldersFilteringEnabled() ?
There was a problem hiding this comment.
ah yes, that applies here as well. I just added the check for that as well. thanks.
…ble bulk form lookup if col.lookup.containerPath defined
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
…teringEnabled when toggleDisabledTooltip
XingY
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
As part of the effort to make "cross folder" action improvements in the apps, this set of PRs takes on the "Edit in Bulk" and "Edit Parents/Sources" actions. This will allow for users with proper permission to edit selected rows in a sample, source, and assay runs/results grid when the set of selections includes rows from multiple containers.
Related Pull Requests
Changes