Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ollama Provider Finalisation #39

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Tanner-Perham
Copy link

@Tanner-Perham Tanner-Perham commented Jan 25, 2025

Description

This Pull Request is for the implementation and testing of the Ollama Provider class. Additionally, an example case is provided for using the Ollama Provider to make an Agent.

Related Issues

Addresses: Issue #11 and Issue #7

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code cleanup or refactor

Implementation Details

  • Updated the Ollama Provider class to include all required methods.
  • Created tests for the Ollama Provider using the OpenAI tests as a template (note, removed bad API key test for Ollama as it does not have an API key).
  • Created an example Agent using the Ollama Provider.

Testing

Testing was done on just the Ollama Provider, as no other components were modified by this feature implementation. Ollama was installed on the local development machine (using the default base URL and Port: localhost:11434) and the llama3.2:3b model was pulled.

  • All existing tests pass
  • Added new tests for the changes
    Test cases added were comparable to the existing OpenAI Provider test cases (sans the invalid API key test).

Documentation Changes

Documentation (when created) should reference installation of Ollama and detail limitations of using smaller models. Some issues with inconsistent outputs were noted in development and attempts have been made to mitigate these using more directive prompting.
It should be noted that for tasks that require tool calling, a tool-enabled model is required. These are tagged 'tool' in the Ollama Model Library.

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

N/A

@Tanner-Perham Tanner-Perham changed the title Ollama Provider Finalisation [FEATURE] Ollama Provider Finalisation Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants