Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 8 and 16 bit integer data types with zfp codec #20

Merged
merged 2 commits into from
May 5, 2024

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented May 5, 2024

Support 8/16-bit integer types with the zfp codec through promotion to 32-bit in accordance with the zfp utility functions.

@LDeakin LDeakin added the enhancement New feature or request label May 5, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 82.21574% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 81.95%. Comparing base (37cbeae) to head (58493ac).

Files Patch % Lines
src/array/codec/array_to_bytes/zfp/zfp_field.rs 27.27% 40 Missing ⚠️
src/array/codec/array_to_bytes/zfp.rs 93.82% 15 Missing ⚠️
...ay/codec/array_to_bytes/zfp/zfp_partial_decoder.rs 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   81.67%   81.95%   +0.28%     
==========================================
  Files         131      132       +1     
  Lines       19303    19528     +225     
==========================================
+ Hits        15765    16004     +239     
+ Misses       3538     3524      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin force-pushed the zfp_small_types branch from d3002fa to 82960b3 Compare May 5, 2024 12:24
@LDeakin LDeakin force-pushed the zfp_small_types branch from 82960b3 to 1e18989 Compare May 5, 2024 12:27
@LDeakin LDeakin force-pushed the zfp_small_types branch from 62db230 to 58493ac Compare May 5, 2024 22:48
@LDeakin LDeakin marked this pull request as ready for review May 5, 2024 22:53
@LDeakin LDeakin merged commit ae57747 into main May 5, 2024
20 checks passed
@LDeakin LDeakin deleted the zfp_small_types branch May 5, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant