Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for setMinFileSize method in FileFilter #121

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

smartfellow1234
Copy link
Contributor

@smartfellow1234 smartfellow1234 commented Oct 15, 2024

Description

Added unit tests for the setMinFileSize method in the FileFilter class to validate that it correctly sets the minimum file size. The tests also ensure that the method handles invalid inputs gracefully and behaves as expected when various sizes are provided.

Type of change

  • Tests update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

Screenshots (if applicable)

image

@techy4shri
Copy link
Collaborator

@smartfellow1234 take a look at what I changed in your description comment and keep that in mind, it will help you nect time you raise a PR.

@smartfellow1234
Copy link
Contributor Author

smartfellow1234 commented Oct 15, 2024 via email

@techy4shri
Copy link
Collaborator

@smartfellow1234 wait for review from Karthik, the PA of this repository for now.

Copy link
Owner

@Kota-Karthik Kota-Karthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smartfellow1234
everything LGTM!

@Kota-Karthik Kota-Karthik merged commit 1e7c45b into Kota-Karthik:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Unit Tests for setMinFileSize Method
3 participants