Menu: improve ergonomy #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJ-Koenig
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Looking good. Seems like a nice clean up.
Code is approved, but I cannot test this right now. @armpitMFG - might need a test from you as well.
Ptibibi
force-pushed
the
ptibibi/improve_menu_code
branch
from
4b6382e to
26feb9d
Compare
Simplify code for encoder management Simplify code to make a menu loop Split code to select menu option and drawing menu Signed-off-by: benoit bobert <benoit.robert.dev@gmail.com>
Create an sub-menu for settings Move settings selection from Menu to MenuSettings Signed-off-by: benoit bobert <benoit.robert.dev@gmail.com>
Ptibibi
force-pushed
the
ptibibi/improve_menu_code
branch
from
26feb9d to
af0ca52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu: improve ergonomy
Software/src/constants/Menu.h
Split Menu to Menu + MenuSettings
Software/src/ossm/OSSM.Menu.cpp
Simplify code to select menu option
Move draw code in a new fonction
Create function task to manage and draw MenuSettings
Software/src/ossm/OSSM.h
Task transition:
MenuSettings:
Software/src/services/tasks.h
Define MenuSettings task