Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote: apply ramp on remote inputs #136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ptibibi
Copy link
Contributor

@Ptibibi Ptibibi commented Nov 1, 2024

Draft - Waiting feature to update settings from UI Initial work for Advanced Settings menu. #127

Feature disable via settings

To enable it, update Lerp value between 1-100

Remote: apply ramp on remote inputs

Reduce injurie risk by appling ramp to limit brutal variation of inputs

Software/src/constants/Config.h

  • Define ramp settings in config

Software/src/ossm/OSSM.PlayControls.cpp

  • Code grouping by usage
  • Unify & init inputs variables
  • Apply ramp on inputs
  • Show inputs ramp on display

Software/src/ossm/OSSM.h

  • create applyRamp() static function to drive ramp

Software/src/extensions/u8g2Extensions.h

  • Update settingBar & settingBarSmall to show ramp

Software/src/structs/SettingPercents.h

  • Removing unused speedKnob variable from SettingPercents

Software/src/ossm/OSSM.SimplePenetration.cpp

  • replaced speedKnob by speed

@Ptibibi Ptibibi changed the title Ptibibi/apply ramp at remote inputs Remote: apply ramp on remote inputs Nov 1, 2024
@Ptibibi Ptibibi force-pushed the ptibibi/apply_ramp_at_remote_inputs branch 2 times, most recently from c219469 to e090529 Compare November 6, 2024 22:59
Copy link
Collaborator

@AJ-Koenig AJ-Koenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for video of functionality, but otherwise, like this approach.

Possible change, maybe rename ramp to lerp.

Signed-off-by: benoit robert <benoit.robert.dev@gmail.com>
@Ptibibi Ptibibi force-pushed the ptibibi/apply_ramp_at_remote_inputs branch from e090529 to f314957 Compare November 12, 2024 07:57
@Ptibibi
Copy link
Contributor Author

Ptibibi commented Nov 12, 2024

Waiting for video of functionality, but otherwise, like this approach.

Possible change, maybe rename ramp to lerp.

@AJ-Koenig, done
ramp to lerp

@Ptibibi
Copy link
Contributor Author

Ptibibi commented Nov 12, 2024

@AJ-Koenig, some pictures and movie in the discord :)

@Ptibibi Ptibibi marked this pull request as draft November 13, 2024 13:30
Reduce injurie risk by appling lerp to limit brutal variation of inputs

Removing speedKnob variable from SettingPercents
- replaced by speed in SimlplePenetration integration file
Code grouping by usage
Update settingBar & settingBarSmall to show lerp variation on inputs

Signed-off-by: benoit robert <benoit.robert.dev@gmail.com>
@Ptibibi Ptibibi force-pushed the ptibibi/apply_ramp_at_remote_inputs branch from f314957 to e70a50f Compare November 13, 2024 18:22
@Ptibibi Ptibibi marked this pull request as ready for review November 13, 2024 18:27
@Ptibibi
Copy link
Contributor Author

Ptibibi commented Nov 13, 2024

Updating settings to disable feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants