Adding barracks fort priority

[dvincent56]

[crudelios]

Instead of the cart image, you have enough space to add actual text next to the checkbox, which I think would be better. Or align the cart image/ checkbox left and add the text to the right of the checkbox.

Also for now I'd rather comment out the archer fort image, that way we can easily add it when we have the forts.

[dvincent56]

Do you prefer the top right position like Grand Temple of Mars ?

[dvincent56]

Remove archery button and place delivery button on top right like grand temple

[crudelios]

This looks good but has merge conflicts now because of the campaign additions.

[dvincent56]

done

[dvincent56]

Areldir wants to revamp the toggle button.

[Areldir]

I'm a nuisance, I know lol

[dvincent56]

I found an issue, I pass the pull request to draft
@crudelios I put comments on my problem, do you know how can I fix it without copy past the military window code in culture window ?
// the building here is the last barracks open instead of grand temple

[dvincent56]

@crudelios Do you have an idea to fix the grand temple update instead of last barracks ?

[dvincent56]

Find a way to fix but I don't know if it's a good way.

[dvincent56]

Breaks the save ...

[crudelios]

Here are some needed changes.

Do note that there's an unfixed issue yet, on old savegames weapons will not be accepted by default.

I'm not sure how to fix that short of bumping the savegame version.

[crudelios]

Good job!

Now either a value of 0 means the good is accepted, which is unintuitive but would work without any change, or we set another control value besides RESOURCE_WEAPONS (RESOURCE_NONE comes to mind) to 1 to signal that the current savegame is already enabling/disabling weapons.

Here's a table:

RESOURCE_NONE	RESOURCE_WEAPONS	Meaning
0	0	Old save format, both should be changed to 1 on game load.
0	1	Shouldn't happen
1	0	New savegame, weapons disabled
1	1	New savegame, weapons enabled

[crudelios]

LGTM 👍