Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update italian.c #1044

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Update italian.c #1044

merged 5 commits into from
Apr 11, 2024

Conversation

berseker
Copy link

Please check this updated Italian translation

Please check this updated Italian translation
Copy link

@luigimannoni luigimannoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed mostly for whitespace and wrong round parenthesis ( instead of braces {.

Translation is 100% accurate, however there are few rows to change:

  • Fetching/not fetching: should have an italian translation, not sure where the string appears so my best guess should be either "Recuperando" or "Prendendo".
  • "Denarii"/"Denari": New translation rows have "Denarii" some old rows have "Denari", I'd like to see "Denarii" rather than the italianization with a single plural "i". Also wikipedia refers it with 2 ii in the plural form which I think was the proper roman name.

thanks to @luigimannoni for the review. fixed all the points.
@berseker
Copy link
Author

just committed a revision - thank you for the comments!

@berseker
Copy link
Author

berseker commented Apr 6, 2024

i do not know how to fix in order to merge this to master

@Ouaz
Copy link

Ouaz commented Apr 6, 2024

  • End of line 515, there's a bracket ) instead of a curly bracket }
src/translation/italian.c:515:70: error: expected ‘}’ before ‘)’ token
  515 |     {TR_WINDOW_ADVISOR_ENTERTAINMENT_TAVERN_COVERAGE_PLURAL,"Taverne"),

Add a commit to fix it, it should be good.

Ah, no, wait, there's more...

  • Line 648: there's a break line here. The entry must be on a single line.

{TR_BUILDING_LARGE_MAUSOLEUM_CONSTRUCTION_DESC, "Per costruire questo mausoleo
_______ richiede materiale conservato in un magazzino, manovalanza da un campo di lavoro e architetti da una corporazione di architetti." },

  • Line 1014: the closing " is missing after azioni
src\translation\italian.c:1014:41: error: missing terminating " character
 1014 |     {TR_EDITOR_SCENARIO_EVENTS_ACTIONS, "azioni },
  • Line 1333: the opening " is missing before Porta

{TR_BUILDING_PANELLED_GARDEN_WALL_GATE, Porta delle mura del giardino a pannelli" },

fixed minor errors thanks to @Ouaz
@berseker
Copy link
Author

berseker commented Apr 7, 2024

  • End of line 515, there's a bracket ) instead of a curly bracket }
src/translation/italian.c:515:70: error: expected ‘}’ before ‘)’ token
  515 |     {TR_WINDOW_ADVISOR_ENTERTAINMENT_TAVERN_COVERAGE_PLURAL,"Taverne"),

Add a commit to fix it, it should be good.

Ah, no, wait, there's more...

  • Line 648: there's a break line here. The entry must be on a single line.

{TR_BUILDING_LARGE_MAUSOLEUM_CONSTRUCTION_DESC, "Per costruire questo mausoleo _______ richiede materiale conservato in un magazzino, manovalanza da un campo di lavoro e architetti da una corporazione di architetti." },

  • Line 1014: the closing " is missing after azioni
src\translation\italian.c:1014:41: error: missing terminating " character
 1014 |     {TR_EDITOR_SCENARIO_EVENTS_ACTIONS, "azioni },
  • Line 1333: the opening " is missing before Porta

{TR_BUILDING_PANELLED_GARDEN_WALL_GATE, Porta delle mura del giardino a pannelli" },

thank you - stupid errors which I could not see since I still do not have confidence with github editor (is there a debug function for syntax errors?

I fixed the above points

Keriew
Keriew previously requested changes Apr 7, 2024
Copy link
Owner

@Keriew Keriew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, looks like there's one tiny change left and then it's ready to merge.

@crudelios crudelios dismissed Keriew’s stale review April 11, 2024 09:30

I've made the requested change myself

@crudelios crudelios merged commit 9a9c00c into Keriew:master Apr 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants