Add Azure support #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takuro-sato
commented
Jan 23, 2024
Comment on lines
112
to
115
| return config_entries_map_.contains(name); | ||
| return config_entries_map_.contains(name) && | ||
| config_entries_map_.at(name) != kEmptyValue; | ||
| } |
There was a problem hiding this comment.
[Comment for actual PR]
This is a change included in the previous PR privacysandbox#7.
takuro-sato
commented
Jan 23, 2024
Comment on lines
-89
to
+92
| google::scp::cpio::PrivateKeyVendingEndpoint primary, secondary; | ||
| google::scp::cpio::PrivateKeyVendingEndpoint primary; |
There was a problem hiding this comment.
[Comment for actual PR]
This file includes changes included the previous PR privacysandbox#7.
They are necessary here to test the other changes.
Co-authored-by: Dominic Ayre <dominicayre@microsoft.com> Co-authored-by: Joe Powell <joepowell@microsoft.com> Co-authored-by: Kapil Vaswani <kapilv@microsoft.com> Co-authored-by: Ken Gordon <Ken.Gordon@microsoft.com> Co-authored-by: Mahati Chamarthy <mahati.chamarthy@microsoft.com> Co-authored-by: Ronny Bjones <ronny.bjones@microsoft.com>
takuro-sato
force-pushed
the
add-azure-support
branch
2 times, most recently
from
ef3080a to
766537f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for the PR
Please check:
Draft for the actual PR↓↓↓
Adding Azure support
This PR is adding support for enabling deployment of Bidding and Auction Services on Azure.
Azure Privacy Sandbox architecture: https://1drv.ms/w/s!AmI-86sms1pYqJ5Uqgo5Qv2Ynmrcmw?e=BDC8BH
(We'll make a PR for the document in https://github.com/privacysandbox/protected-auction-services-docs/tree/main in future)
Now B&A services can fetch private and public HPKE keys from an Azure KMS, specifically designed to support the B&A services, and handle test requests.
To try this changes locally, please visit here.
The PR for data-plane-shared-libraries repository: [TODO: link]
Changes
--platform=azure(for Bazel),kAzure(C++ enum value).production/packagingkAzure.TODOs for future PRs