[Feat] sologame 기록 저장 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results22 tests 22 ✅ 3s ⏱️ Results for commit 406f0ce. ♻️ This comment has been updated with latest results. |
david-parkk
reviewed
Sep 28, 2024
| private final RhythmScoreService rhythmScoreService; | ||
|
|
||
| // 저장 | ||
| @PostMapping("/rhythm") |
There was a problem hiding this comment.
restful API에서는 rhythms으로 하지 않나요?
| private int score; | ||
|
|
||
| @Column(name = "created_at", nullable = false, updatable = false) | ||
| @CreationTimestamp |
There was a problem hiding this comment.
1주일에 대한 랭킹 제공이라면 게임 전적에 대한 랭킹 포함 여부를 결정하는 enum으로 이해했어요
There was a problem hiding this comment.
저거는 사용자가 캐릭터를 삭제할 경우 기록에서 표시하기 위한 필드였습니다. 랭킹에 대해서는 고민하고 있는 부분이 있는데 회의에서 이야기 하도록 하겠습니다.
david-parkk
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 작업 개요
sologame 기록 저장
⛳ 작업 분류
🔨 작업 상세 내용
💡 생각해볼 문제