-
Notifications
You must be signed in to change notification settings - Fork 5
Spatial tree interface #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
utils/utils.jl
and add edge list functionality
rafaqz
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, these are maybe a bit perfectionist comments but some of these things are quite hard to understand so its worth working over the naming and docstings a little
(but no tests yet, need to add those!)
Co-authored-by: Rafael Schouten <rafaelschouten@gmail.com>
Maybe this is a bad idea, single file was nice for readability. But we can keep going.
97015f9
to
fa4876a
Compare
bfd57aa
to
d5a49de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spatial Trees
This PR performs all the necessary actions to add a spatial tree interface and surrounding machinery to GeometryOps. Actually accelerating GeometryOps functions with the spatial trees is left for another PR - we don't tackle that in this one.
This implements, at a high level, functional, non-allocating single-tree and dual tree queries over arbitrary predicates.
SpatialTreeInterface
Introduces a new SpatialTreeInterface module that provides an interface for spatial trees, built somewhat on top of AbstractTrees.jl.
LoopStateMachine
Introduces a new
LoopStateMachine
module that provides utilities for returning state from functions running inside loops. This is particularly useful for operations like clipping where state transitions or early termination may be needed.The module includes:
Action
struct for representing different control flow actions@controlflow
macro for processing actions within loops:continue
,:break
,:return
, and:full_return
actionsComprehensive tests verify all supported actions work correctly.