Skip to content

Commit

Permalink
Fix GH#24941: revert exchange of staccatissimo and spiccato
Browse files Browse the repository at this point in the history
Backport of musescore#25428
  • Loading branch information
Jojo-Schmitz committed Feb 27, 2025
1 parent 60280a3 commit 60ecc37
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions importexport/musicxml/exportxml.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2863,6 +2863,8 @@ static std::vector<QString> symIdToArtics(const SymId sid)
return { "staccato" };
break;

case SymId::articStaccatissimoAbove:
case SymId::articStaccatissimoBelow:
case SymId::articStaccatissimoWedgeAbove:
case SymId::articStaccatissimoWedgeBelow:
return { "staccatissimo" };
Expand Down Expand Up @@ -2933,8 +2935,6 @@ static std::vector<QString> symIdToArtics(const SymId sid)
return { "tenuto", "accent" };
break;

case SymId::articStaccatissimoAbove:
case SymId::articStaccatissimoBelow:
case SymId::articStaccatissimoStrokeAbove:
case SymId::articStaccatissimoStrokeBelow:
return { "spiccato" };
Expand Down
4 changes: 2 additions & 2 deletions importexport/musicxml/importmxmlpass2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1288,8 +1288,8 @@ static bool convertArticulationToSymId(const QString& mxmlName, SymId& id)
map["staccato"] = SymId::articStaccatoAbove;
map["tenuto"] = SymId::articTenutoAbove;
map["detached-legato"] = SymId::articTenutoStaccatoAbove;
map["staccatissimo"] = SymId::articStaccatissimoWedgeAbove;
map["spiccato"] = SymId::articStaccatissimoAbove;
map["staccatissimo"] = SymId::articStaccatissimoAbove;
map["spiccato"] = SymId::articStaccatissimoStrokeAbove;
map["stress"] = SymId::articStressAbove;
map["unstress"] = SymId::articUnstressAbove;
map["soft-accent"] = SymId::articSoftAccentAbove;
Expand Down
6 changes: 3 additions & 3 deletions mtest/musicxml/io/testNoteAttributes2_ref.mscx
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
<Chord>
<durationType>quarter</durationType>
<Articulation>
<subtype>articStaccatissimoWedgeAbove</subtype>
<subtype>articStaccatissimoAbove</subtype>
</Articulation>
<StemDirection>down</StemDirection>
<Note>
Expand All @@ -196,7 +196,7 @@
<Chord>
<durationType>quarter</durationType>
<Articulation>
<subtype>articStaccatissimoWedgeAbove</subtype>
<subtype>articStaccatissimoAbove</subtype>
</Articulation>
<StemDirection>down</StemDirection>
<Note>
Expand Down Expand Up @@ -451,7 +451,7 @@
<Chord>
<durationType>quarter</durationType>
<Articulation>
<subtype>articStaccatissimoBelow</subtype>
<subtype>articStaccatissimoStrokeBelow</subtype>
</Articulation>
<StemDirection>up</StemDirection>
<Note>
Expand Down

0 comments on commit 60ecc37

Please sign in to comment.