Skip to content

Commit

Permalink
Update OrJanusPredicateTest.java
Browse files Browse the repository at this point in the history
Improves the readability of the test. The assertions are clearer and include descriptive messages, making it easier to identify which assertion fails. This enhances code maintainability, understanding and debugging efficiency.

Signed-off-by: Rian-Ismael <106334437+Rian-Ismael@users.noreply.github.com>
  • Loading branch information
Rian-Ismael committed Feb 4, 2025
1 parent 46a971a commit 8ae5d2b
Showing 1 changed file with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,10 @@ ConnectiveJanusPredicate getNegatePredicate(List<JanusGraphPredicate> childPredi

@Test
public void testIsQNF() {
assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)).isQNF());
assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new OrJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF());
assertFalse(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new AndJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF());
assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)).isQNF(), "Single PREFIX EQUAL should be QNF");
assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new OrJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF(),
"PREFIX EQUAL with OR(JANUS(PREFIX EQUAL)) should be QNF");
assertFalse(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new AndJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF(),
"PREFIX EQUAL with AND(JANUS(PREFIX EQUAL)) should not be QNF");
}
}

0 comments on commit 8ae5d2b

Please sign in to comment.