Skip to content

Commit

Permalink
Fix NPE on keyspace creation
Browse files Browse the repository at this point in the history 
Signed-off-by: Dylan Werner-Meier <dylan.bloger@gmail.com>
  • Loading branch information
@unautre @li-boxuan
unautre authored and li-boxuan committed Jun 22, 2024
1 parent 0f2bdfd commit 4fd338b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLStoreManager.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ public void close() throws BackendException {
ExceptionWrapper exceptionWrapper = new ExceptionWrapper();
executeWithCatching(this::clearJmxMetrics, exceptionWrapper);
executeWithCatching(session::close, exceptionWrapper);
executeWithCatching(queriesBackPressure::close, exceptionWrapper);
if (queriesBackPressure != null) executeWithCatching(queriesBackPressure::close, exceptionWrapper);
throwIfException(exceptionWrapper);
} finally {
gracefulExecutorServiceShutdown(executorService, threadPoolShutdownMaxWaitTime);
Expand Down

1 comment on commit 4fd338b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 4fd338b Previous: d35fc64 Ratio
org.janusgraph.JanusGraphSpeedBenchmark.basicAddAndDelete 12424.290740597304 ms/op 12468.444225291154 ms/op 1.00
org.janusgraph.GraphCentricQueryBenchmark.getVertices 896.8385911654806 ms/op 918.3423996712321 ms/op 0.98
org.janusgraph.MgmtOlapJobBenchmark.runClearIndex 215.453410567029 ms/op 216.65935547028985 ms/op 0.99
org.janusgraph.MgmtOlapJobBenchmark.runReindex 342.7441531070512 ms/op 336.6219472083333 ms/op 1.02
org.janusgraph.JanusGraphSpeedBenchmark.basicCount 191.68470963269905 ms/op 212.17318113485976 ms/op 0.90
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 4734.100752181283 ms/op 4934.862177070978 ms/op 0.96
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingEmitRepeatSteps 16597.01159874485 ms/op 17119.84681319412 ms/op 0.97
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithSmallBatch 19218.540966934343 ms/op 20987.51313056889 ms/op 0.92
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.vertexCentricPropertiesFetching 54835.81969353334 ms/op 57050.64306146667 ms/op 0.96
org.janusgraph.CQLMultiQueryDropBenchmark.dropVertices 1536.1245358877152 ms/op 1559.969298241005 ms/op 0.98
org.janusgraph.CQLMultiQueryBenchmark.getAllElementsTraversedFromOuterVertex 8177.466771426903 ms/op 8318.72392928847 ms/op 0.98
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithDoubleUnion 377.4377601004802 ms/op 392.59846986303853 ms/op 0.96
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesAllPropertiesWithUnlimitedBatch 4180.005949791264 ms/op 4240.712364445486 ms/op 0.99
org.janusgraph.CQLMultiQueryBenchmark.getNames 8142.004904959496 ms/op 8406.331584402715 ms/op 0.97
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesThreePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 5486.667620931406 ms/op 5987.64859878139 ms/op 0.92
org.janusgraph.CQLMultiQueryBenchmark.getLabels 7066.109654708413 ms/op 7290.028061798635 ms/op 0.97
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFilteredByAndStep 427.008535819701 ms/op 435.76237709334333 ms/op 0.98
org.janusgraph.CQLMultiQueryBenchmark.getVerticesFromMultiNestedRepeatStepStartingFromSingleVertex 11904.190790192943 ms/op 12783.126217693469 ms/op 0.93
org.janusgraph.CQLMultiQueryBenchmark.getVerticesWithCoalesceUsage 365.25783413774707 ms/op 363.9668594437082 ms/op 1.00
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithAllMultiQuerySlicesUnderMaxRequestsPerConnection 14180.319382537478 ms/op 15378.720663330263 ms/op 0.92
org.janusgraph.CQLMultiQueryBenchmark.getIdToOutVerticesProjection 244.4618475511506 ms/op 253.97183167148802 ms/op 0.96
org.janusgraph.CQLMultiQueryMultiSlicesBenchmark.getValuesMultiplePropertiesWithUnlimitedBatch 13569.44996752203 ms/op 14617.308247215036 ms/op 0.93
org.janusgraph.CQLMultiQueryBenchmark.getNeighborNames 8209.430719026628 ms/op 8414.490379754512 ms/op 0.98
org.janusgraph.CQLMultiQueryBenchmark.getElementsWithUsingRepeatUntilSteps 8948.963608094176 ms/op 9340.049792997386 ms/op 0.96
org.janusgraph.CQLMultiQueryBenchmark.getAdjacentVerticesLocalCounts 8330.74594555653 ms/op 8726.780923948296 ms/op 0.95

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.